mbox series

[0/6,v3] btrfs-progs: cleanup and preparatory around device scan

Message ID cover.1686484067.git.anand.jain@oracle.com (mailing list archive)
Headers show
Series btrfs-progs: cleanup and preparatory around device scan | expand

Message

Anand Jain June 13, 2023, 10:26 a.m. UTC 
v3: Contains fixes as per review comments; details are in the individual
    patches.

    Patches dropped:
      btrfs-progs: check_mounted_where: pack varibles type by size
      btrfs-progs: btrfs_scan_one_device: drop local variable ret
    Patch added:
      btrfs-progs: drop open_ctree_flags in cmd_inspect_dump_tree

v2: I have separated preparatory and cleanups from the introduction of new
    features so that they can be easily modified with a smaller set of patches.

    Added missing git changelogs. (Looks like sshfs lost my last few changes,
    now fixed).

--- original cover page ---
In an attempt to enable btrfstune to accept multiple devices from the
command line, this patch includes some cleanup around the related
preparatory work around the device scan code.

Patches 1 to 5 primarily consist of cleanups. Patches 6 and 7 serve as
preparatory changes.

Anand Jain (6):
  btrfs-progs: check_mounted_where: declare is_btrfs as bool
  btrfs-progs: rename struct open_ctree_flags to open_ctree_args
  btrfs-progs: drop open_ctree_flags in cmd_inspect_dump_tree
  btrfs-progs: device_list_add: optimize arguments drop devid
  btrfs-progs: factor out btrfs_scan_argv_devices
  btrfs-progs: refactor check_where_mounted with noscan argument

 btrfs-find-root.c        |  8 +++---
 check/main.c             | 14 +++++-----
 cmds/filesystem.c        |  8 +++---
 cmds/inspect-dump-tree.c | 55 ++++++++--------------------------------
 cmds/rescue.c            | 16 ++++++------
 cmds/restore.c           | 12 ++++-----
 common/device-scan.c     | 40 +++++++++++++++++++++++++++++
 common/device-scan.h     |  1 +
 common/open-utils.c      | 11 +++++---
 common/open-utils.h      |  3 ++-
 common/utils.c           |  3 ++-
 image/main.c             | 16 ++++++------
 kernel-shared/disk-io.c  | 50 ++++++++++++++++++------------------
 kernel-shared/disk-io.h  |  4 +--
 kernel-shared/volumes.c  | 10 +++-----
 mkfs/main.c              |  8 +++---
 tune/main.c              |  2 +-
 17 files changed, 136 insertions(+), 125 deletions(-)

Comments

David Sterba June 28, 2023, 10:24 p.m. UTC | #1 
On Tue, Jun 13, 2023 at 06:26:51PM +0800, Anand Jain wrote:
> v3: Contains fixes as per review comments; details are in the individual
>     patches.
> 
>     Patches dropped:
>       btrfs-progs: check_mounted_where: pack varibles type by size
>       btrfs-progs: btrfs_scan_one_device: drop local variable ret
>     Patch added:
>       btrfs-progs: drop open_ctree_flags in cmd_inspect_dump_tree
> 
> v2: I have separated preparatory and cleanups from the introduction of new
>     features so that they can be easily modified with a smaller set of patches.
> 
>     Added missing git changelogs. (Looks like sshfs lost my last few changes,
>     now fixed).
> 
> --- original cover page ---
> In an attempt to enable btrfstune to accept multiple devices from the
> command line, this patch includes some cleanup around the related
> preparatory work around the device scan code.
> 
> Patches 1 to 5 primarily consist of cleanups. Patches 6 and 7 serve as
> preparatory changes.
> 
> Anand Jain (6):
>   btrfs-progs: check_mounted_where: declare is_btrfs as bool
>   btrfs-progs: rename struct open_ctree_flags to open_ctree_args
>   btrfs-progs: drop open_ctree_flags in cmd_inspect_dump_tree
>   btrfs-progs: device_list_add: optimize arguments drop devid
>   btrfs-progs: factor out btrfs_scan_argv_devices
>   btrfs-progs: refactor check_where_mounted with noscan argument

Added to devel, thanks.