mbox series

[v2,net,0/3] Fix PTP packet drops with ocelot-8021q DSA tag protocol

Message ID 20230627163114.3561597-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series Fix PTP packet drops with ocelot-8021q DSA tag protocol | expand

Message

Vladimir Oltean June 27, 2023, 4:31 p.m. UTC 
Changes in v2:
- Distinguish between L2 and L4 PTP packets
v1 at:
https://lore.kernel.org/netdev/20230626154003.3153076-1-vladimir.oltean@nxp.com/

Patch 3/3 fixes an issue with the ocelot/felix driver, where it would
drop PTP traffic on RX unless hardware timestamping for that packet type
was enabled.

Fixing that requires the driver to know whether it had previously
configured the hardware to timestamp PTP packets on that port. But it
cannot correctly determine that today using the existing code structure,
so patches 1/3 and 2/3 fix the control path of the code such that
ocelot->ports[port]->trap_proto faithfully reflects whether that
configuration took place.

Vladimir Oltean (3):
  net: mscc: ocelot: don't report that RX timestamping is enabled by
    default
  net: mscc: ocelot: don't keep PTP configuration of all ports in single
    structure
  net: dsa: felix: don't drop PTP frames with tag_8021q when RX
    timestamping is disabled

 drivers/net/dsa/ocelot/felix.c         | 12 +++++
 drivers/net/ethernet/mscc/ocelot.c     |  1 -
 drivers/net/ethernet/mscc/ocelot_ptp.c | 66 ++++++++++++++++----------
 include/soc/mscc/ocelot.h              | 10 ++--
 4 files changed, 60 insertions(+), 29 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org June 29, 2023, 11 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 27 Jun 2023 19:31:11 +0300 you wrote:
> Changes in v2:
> - Distinguish between L2 and L4 PTP packets
> v1 at:
> https://lore.kernel.org/netdev/20230626154003.3153076-1-vladimir.oltean@nxp.com/
> 
> Patch 3/3 fixes an issue with the ocelot/felix driver, where it would
> drop PTP traffic on RX unless hardware timestamping for that packet type
> was enabled.
> 
> [...]

Here is the summary with links:
  - [v2,net,1/3] net: mscc: ocelot: don't report that RX timestamping is enabled by default
    https://git.kernel.org/netdev/net/c/4fd44b82b7ac
  - [v2,net,2/3] net: mscc: ocelot: don't keep PTP configuration of all ports in single structure
    https://git.kernel.org/netdev/net/c/45d0fcb5bc95
  - [v2,net,3/3] net: dsa: felix: don't drop PTP frames with tag_8021q when RX timestamping is disabled
    https://git.kernel.org/netdev/net/c/2edcfcbb3c59

You are awesome, thank you!