Message ID | ZJt7LKzjdz8+dClx@tobhe.de (mailing list archive) |
---|---|
State | Accepted |
Commit | 046f753da6143ee16452966915087ec8b0de3c70 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | Add MODULE_FIRMWARE() for FIRMWARE_TG357766. | expand |
On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <me@tobhe.de> wrote: > > Fixes a bug where on the M1 mac mini initramfs-tools fails to > include the necessary firmware into the initrd. > > Signed-off-by: Tobias Heider <me@tobhe.de> Thanks. Reviewed-by: Michael Chan <michael.chan@broadcom.com>
On Tue, 2023-06-27 at 18:31 -0700, Michael Chan wrote: > On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <me@tobhe.de> wrote: > > > > Fixes a bug where on the M1 mac mini initramfs-tools fails to > > include the necessary firmware into the initrd. > > > > Signed-off-by: Tobias Heider <me@tobhe.de> > > Thanks. > Reviewed-by: Michael Chan <michael.chan@broadcom.com> This is a borderline situation, but ... Is there a suitable 'Fixes:' tag we can add here? Thanks! Paolo
On Thu, Jun 29, 2023 at 03:05:23PM +0200, Paolo Abeni wrote: > On Tue, 2023-06-27 at 18:31 -0700, Michael Chan wrote: > > On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <me@tobhe.de> wrote: > > > > > > Fixes a bug where on the M1 mac mini initramfs-tools fails to > > > include the necessary firmware into the initrd. > > > > > > Signed-off-by: Tobias Heider <me@tobhe.de> > > > > Thanks. > > Reviewed-by: Michael Chan <michael.chan@broadcom.com> > > This is a borderline situation, but ... > > Is there a suitable 'Fixes:' tag we can add here? > > Thanks! > > Paolo > Would "Fixes: c4dab50697ff ("video: remove unnecessary platform_set_drvdata()")" work?
On Thu, 29 Jun 2023 15:37:05 +0200 Tobias Heider wrote: > Would "Fixes: c4dab50697ff ("video: remove unnecessary platform_set_drvdata()")" > work? Modulo the text in the brackets but yes ;) I'll add when applying.
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 28 Jun 2023 02:13:32 +0200 you wrote: > Fixes a bug where on the M1 mac mini initramfs-tools fails to > include the necessary firmware into the initrd. > > Signed-off-by: Tobias Heider <me@tobhe.de> > --- > drivers/net/ethernet/broadcom/tg3.c | 1 + > 1 file changed, 1 insertion(+) Here is the summary with links: - Add MODULE_FIRMWARE() for FIRMWARE_TG357766. https://git.kernel.org/netdev/net/c/046f753da614 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 58747292521d..a52cf9aae498 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -224,6 +224,7 @@ MODULE_AUTHOR("David S. Miller (davem@redhat.com) and Jeff Garzik (jgarzik@pobox MODULE_DESCRIPTION("Broadcom Tigon3 ethernet driver"); MODULE_LICENSE("GPL"); MODULE_FIRMWARE(FIRMWARE_TG3); +MODULE_FIRMWARE(FIRMWARE_TG357766); MODULE_FIRMWARE(FIRMWARE_TG3TSO); MODULE_FIRMWARE(FIRMWARE_TG3TSO5);
Fixes a bug where on the M1 mac mini initramfs-tools fails to include the necessary firmware into the initrd. Signed-off-by: Tobias Heider <me@tobhe.de> --- drivers/net/ethernet/broadcom/tg3.c | 1 + 1 file changed, 1 insertion(+)