diff mbox series

[next] btrfs: scrub: remove redundant division of stripe_nr

Message ID 20230621130937.2676434-1-colin.i.king@gmail.com (mailing list archive)
State New, archived
Headers show
Series [next] btrfs: scrub: remove redundant division of stripe_nr | expand

Commit Message

Colin Ian King June 21, 2023, 1:09 p.m. UTC
Variable stripe_nr is being divided by map->num_stripes however the
result is never read. The division and assignment are redundant and
can be removed. Cleans up clang scan build warning:

fs/btrfs/scrub.c:1264:3: warning: Value stored to 'stripe_nr' is
never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/btrfs/scrub.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Sterba June 29, 2023, 3:17 p.m. UTC | #1
On Wed, Jun 21, 2023 at 02:09:37PM +0100, Colin Ian King wrote:
> Variable stripe_nr is being divided by map->num_stripes however the
> result is never read. The division and assignment are redundant and
> can be removed. Cleans up clang scan build warning:
> 
> fs/btrfs/scrub.c:1264:3: warning: Value stored to 'stripe_nr' is
> never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Added to misc-next, thanks.
diff mbox series

Patch

diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index 2c7fdbb60314..8fc4f9ea3d20 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -1261,7 +1261,6 @@  static int get_raid56_logic_offset(u64 physical, int num,
 
 		/* Work out the disk rotation on this stripe-set */
 		rot = stripe_nr % map->num_stripes;
-		stripe_nr /= map->num_stripes;
 		/* calculate which stripe this data locates */
 		rot += i;
 		stripe_index = rot % map->num_stripes;