Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()

Commit Message

Dan Carpenter July 3, 2023, 2:17 p.m. UTC

Return negative -EIO instead of positive EIO.

Fixes: 926df8962f3f ("Bluetooth: msft: Extended monitor tracking by address filter")
Signed-off-by: Dan Carpenter <[e-mail]>
---
 net/bluetooth/msft.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] July 3, 2023, 2:59 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=762052

---Test result---

Test Summary:
CheckPatch                    PASS      0.57 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      33.51 seconds
CheckAllWarning               PASS      36.46 seconds
CheckSparse                   PASS      41.12 seconds
CheckSmatch                   PASS      115.33 seconds
BuildKernel32                 PASS      32.10 seconds
TestRunnerSetup               PASS      460.82 seconds
TestRunner_l2cap-tester       PASS      13.21 seconds
TestRunner_iso-tester         PASS      23.96 seconds
TestRunner_bnep-tester        PASS      5.61 seconds
TestRunner_mgmt-tester        PASS      132.90 seconds
TestRunner_rfcomm-tester      PASS      9.20 seconds
TestRunner_sco-tester         PASS      10.54 seconds
TestRunner_ioctl-tester       PASS      9.73 seconds
TestRunner_mesh-tester        PASS      7.20 seconds
TestRunner_smp-tester         PASS      8.30 seconds
TestRunner_userchan-tester    PASS      5.91 seconds
IncrementalBuild              PASS      30.54 seconds



---
Regards,
Linux Bluetooth

Simon Horman July 5, 2023, 7:40 a.m. UTC | #2

On Mon, Jul 03, 2023 at 05:17:16PM +0300, Dan Carpenter wrote:
> Return negative -EIO instead of positive EIO.
> 
> Fixes: 926df8962f3f ("Bluetooth: msft: Extended monitor tracking by address filter")
> Signed-off-by: Dan Carpenter <[e-mail]>

Reviewed-by: Simon Horman <[e-mail]>

[e-mail] July 5, 2023, 11 p.m. UTC | #3

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Mon, 3 Jul 2023 17:17:16 +0300 you wrote:
> Return negative -EIO instead of positive EIO.
> 
> Fixes: 926df8962f3f ("Bluetooth: msft: Extended monitor tracking by address filter")
> Signed-off-by: Dan Carpenter <[e-mail]>
> ---
>  net/bluetooth/msft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()
    https://git.kernel.org/bluetooth/bluetooth-next/c/375f2744ab84

You are awesome, thank you!

Patch

diff --git a/net/bluetooth/msft.c b/net/bluetooth/msft.c
index b80a2162a5c3..abbafa6194ca 100644
--- a/net/bluetooth/msft.c
+++ b/net/bluetooth/msft.c
@@ -743,7 +743,7 @@  static int msft_cancel_address_filter_sync(struct hci_dev *hdev, void *data)
 	if (IS_ERR_OR_NULL(skb)) {
 		bt_dev_err(hdev, "MSFT: Failed to cancel address (%pMR) filter",
 			   &address_filter->bdaddr);
-		err = EIO;
+		err = -EIO;
 		goto done;
 	}
 	kfree_skb(skb);