| Message ID | 20230630134506.109269-3-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IVSC support for IPU bridge | expand |
On Fri, Jun 30, 2023 at 04:45:06PM +0300, Sakari Ailus wrote: > Switch to EXPORT_SYMBOL_NS_GPL() on ipu_bridge_instantiate_vcm(). The rest > of the ipu bridge symbols are this way already. Hmm... This actually changes the license, Why is it initially non-GPL and what are the consequences of this change? ... > -EXPORT_SYMBOL(ipu_bridge_instantiate_vcm); > +EXPORT_SYMBOL_NS_GPL(ipu_bridge_instantiate_vcm, INTEL_IPU_BRIDGE);
Hi Andy, On Fri, Jun 30, 2023 at 08:46:49PM +0300, Andy Shevchenko wrote: > On Fri, Jun 30, 2023 at 04:45:06PM +0300, Sakari Ailus wrote: > > Switch to EXPORT_SYMBOL_NS_GPL() on ipu_bridge_instantiate_vcm(). The rest > > of the ipu bridge symbols are this way already. > > Hmm... This actually changes the license, Why is it initially non-GPL and what > are the consequences of this change? This does not change the license. It's just that the function will be only available for GPL'd users. I'd think the reason why the plain EXPORT_SYMBOL() is used is plainly historical. In any case, after Hans's set the other two functions required for using the IPU bridge are GPL-only.
Hi, On 7/5/23 12:49, Sakari Ailus wrote: > Hi Andy, > > On Fri, Jun 30, 2023 at 08:46:49PM +0300, Andy Shevchenko wrote: >> On Fri, Jun 30, 2023 at 04:45:06PM +0300, Sakari Ailus wrote: >>> Switch to EXPORT_SYMBOL_NS_GPL() on ipu_bridge_instantiate_vcm(). The rest >>> of the ipu bridge symbols are this way already. >> >> Hmm... This actually changes the license, Why is it initially non-GPL and what >> are the consequences of this change? > > This does not change the license. It's just that the function will be > only available for GPL'd users. I'd think the reason why the plain > EXPORT_SYMBOL() is used is plainly historical. > > In any case, after Hans's set the other two functions required for using > the IPU bridge are GPL-only. Right I'll fix this in v3 of my series so that this symbol uses EXPORT_SYMBOL_NS_GPL() from the get go like the other 2 symbols. Regards, Hans
diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c index 2811e716ea62..c2f62d98a655 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -549,7 +549,7 @@ int ipu_bridge_instantiate_vcm(struct device *sensor) return 0; } -EXPORT_SYMBOL(ipu_bridge_instantiate_vcm); +EXPORT_SYMBOL_NS_GPL(ipu_bridge_instantiate_vcm, INTEL_IPU_BRIDGE); static int ipu_bridge_instantiate_ivsc(struct ipu_sensor *sensor) {
Switch to EXPORT_SYMBOL_NS_GPL() on ipu_bridge_instantiate_vcm(). The rest of the ipu bridge symbols are this way already. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/pci/intel/ipu-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)