mbox series

[0/6] mmc-utils: ffu: ffu of large images

Message ID 20230625103814.105-1-avri.altman@wdc.com (mailing list archive)
Headers show
Series mmc-utils: ffu: ffu of large images | expand

Message

Avri Altman June 25, 2023, 10:38 a.m. UTC
ffu is done using a single multi-ioctl to carry the entire firmware
image. This is limiting the fw image size to be at most 512KB, as the
mmc driver restricts each single ioc data to be at most
MMC_IOC_MAX_BYTES.

The spec however, allows the fw image to be written using multiple write
commands. So if the fw image is larger than 512KB, split it into a
series of smaller chunks.

Avri Altman (6):
  mmc-utils: Add fill_switch_cmd handler
  mmc-utils: Add arg argument to set_single_cmd
  mmc-utils: ffu: Simplify ext_csd bytes parsing
  mmc-utils: ffu: Add ffu multi-command set handler
  mmc-utils: ffu: Allow ffu of large images
  mmc-utils: ffu: Add optional chunk-size argument

 mmc.c      |   6 +-
 mmc_cmds.c | 161 +++++++++++++++++++++++++++--------------------------
 2 files changed, 86 insertions(+), 81 deletions(-)

Comments

Avri Altman July 6, 2023, 7:43 a.m. UTC | #1
Hi,
Would appreciate your comments.

Thanks,
Avri

> -----Original Message-----
> From: Avri Altman <avri.altman@wdc.com>
> Sent: Sunday, June 25, 2023 1:38 PM
> To: Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org
> Cc: Avri Altman <Avri.Altman@wdc.com>
> Subject: [PATCH 0/6] mmc-utils: ffu: ffu of large images
> 
> ffu is done using a single multi-ioctl to carry the entire firmware image. This is
> limiting the fw image size to be at most 512KB, as the mmc driver restricts
> each single ioc data to be at most MMC_IOC_MAX_BYTES.
> 
> The spec however, allows the fw image to be written using multiple write
> commands. So if the fw image is larger than 512KB, split it into a series of
> smaller chunks.
> 
> Avri Altman (6):
>   mmc-utils: Add fill_switch_cmd handler
>   mmc-utils: Add arg argument to set_single_cmd
>   mmc-utils: ffu: Simplify ext_csd bytes parsing
>   mmc-utils: ffu: Add ffu multi-command set handler
>   mmc-utils: ffu: Allow ffu of large images
>   mmc-utils: ffu: Add optional chunk-size argument
> 
>  mmc.c      |   6 +-
>  mmc_cmds.c | 161 +++++++++++++++++++++++++++--------------------------
>  2 files changed, 86 insertions(+), 81 deletions(-)
> 
> --
> 2.40.1
Avri Altman July 13, 2023, 7:12 a.m. UTC | #2
> Hi,
> Would appreciate your comments.
A gentle ping.

Thanks,
Avri

> 
> Thanks,
> Avri
> 
> > -----Original Message-----
> > From: Avri Altman <avri.altman@wdc.com>
> > Sent: Sunday, June 25, 2023 1:38 PM
> > To: Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org
> > Cc: Avri Altman <Avri.Altman@wdc.com>
> > Subject: [PATCH 0/6] mmc-utils: ffu: ffu of large images
> >
> > ffu is done using a single multi-ioctl to carry the entire firmware
> > image. This is limiting the fw image size to be at most 512KB, as the
> > mmc driver restricts each single ioc data to be at most
> MMC_IOC_MAX_BYTES.
> >
> > The spec however, allows the fw image to be written using multiple
> > write commands. So if the fw image is larger than 512KB, split it into
> > a series of smaller chunks.
> >
> > Avri Altman (6):
> >   mmc-utils: Add fill_switch_cmd handler
> >   mmc-utils: Add arg argument to set_single_cmd
> >   mmc-utils: ffu: Simplify ext_csd bytes parsing
> >   mmc-utils: ffu: Add ffu multi-command set handler
> >   mmc-utils: ffu: Allow ffu of large images
> >   mmc-utils: ffu: Add optional chunk-size argument
> >
> >  mmc.c      |   6 +-
> >  mmc_cmds.c | 161
> > +++++++++++++++++++++++++++--------------------------
> >  2 files changed, 86 insertions(+), 81 deletions(-)
> >
> > --
> > 2.40.1
Avri Altman July 23, 2023, 5 a.m. UTC | #3
> > Hi,
> > Would appreciate your comments.
> A gentle ping.
And a 2nd one.

Thanks,
Avri

> 
> Thanks,
> Avri
> 
> >
> > Thanks,
> > Avri
> >
> > > -----Original Message-----
> > > From: Avri Altman <avri.altman@wdc.com>
> > > Sent: Sunday, June 25, 2023 1:38 PM
> > > To: Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org
> > > Cc: Avri Altman <Avri.Altman@wdc.com>
> > > Subject: [PATCH 0/6] mmc-utils: ffu: ffu of large images
> > >
> > > ffu is done using a single multi-ioctl to carry the entire firmware
> > > image. This is limiting the fw image size to be at most 512KB, as
> > > the mmc driver restricts each single ioc data to be at most
> > MMC_IOC_MAX_BYTES.
> > >
> > > The spec however, allows the fw image to be written using multiple
> > > write commands. So if the fw image is larger than 512KB, split it
> > > into a series of smaller chunks.
> > >
> > > Avri Altman (6):
> > >   mmc-utils: Add fill_switch_cmd handler
> > >   mmc-utils: Add arg argument to set_single_cmd
> > >   mmc-utils: ffu: Simplify ext_csd bytes parsing
> > >   mmc-utils: ffu: Add ffu multi-command set handler
> > >   mmc-utils: ffu: Allow ffu of large images
> > >   mmc-utils: ffu: Add optional chunk-size argument
> > >
> > >  mmc.c      |   6 +-
> > >  mmc_cmds.c | 161
> > > +++++++++++++++++++++++++++--------------------------
> > >  2 files changed, 86 insertions(+), 81 deletions(-)
> > >
> > > --
> > > 2.40.1
Ulf Hansson Aug. 7, 2023, 11:13 a.m. UTC | #4
On Sun, 25 Jun 2023 at 12:38, Avri Altman <avri.altman@wdc.com> wrote:
>
> ffu is done using a single multi-ioctl to carry the entire firmware
> image. This is limiting the fw image size to be at most 512KB, as the
> mmc driver restricts each single ioc data to be at most
> MMC_IOC_MAX_BYTES.
>
> The spec however, allows the fw image to be written using multiple write
> commands. So if the fw image is larger than 512KB, split it into a
> series of smaller chunks.
>
> Avri Altman (6):
>   mmc-utils: Add fill_switch_cmd handler
>   mmc-utils: Add arg argument to set_single_cmd
>   mmc-utils: ffu: Simplify ext_csd bytes parsing
>   mmc-utils: ffu: Add ffu multi-command set handler
>   mmc-utils: ffu: Allow ffu of large images
>   mmc-utils: ffu: Add optional chunk-size argument
>
>  mmc.c      |   6 +-
>  mmc_cmds.c | 161 +++++++++++++++++++++++++++--------------------------
>  2 files changed, 86 insertions(+), 81 deletions(-)
>

Apologies for the delay! Applied to
git.kernel.org/pub/scm/utils/mmc/mmc-utils.git master, thanks!

Kind regards
Uffe