| Message ID | 20230524074847.866711-1-stanislaw.gruszka@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | accel/ivpu: Add debugfs support | expand |
On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> wrote: > > Add debugfs support for ivpu driver, most importantly firmware loging > and tracing. Hi, Without looking at the code I have 2 comments/questions: 1. Please add an ABI documentation in Documentation/ABI/testing/ or Documentation/ABI/stable (if you are feeling courageous). You can see for example habana's file at Documentation/ABI/testing/debugfs-driver-habanalabs 2. Is this synced with Christian's upcoming changes to the debugfs infra in drm ? If not, I might suggest to sync with that and wait until those patches are merged because they change the layout of debugfs nodes. Oded > > Andrzej Kacprowski (1): > accel/ivpu: Print firmware name and version > > Krystian Pradzynski (1): > accel/ivpu: Add fw_name file to debugfs > > Stanislaw Gruszka (3): > accel/ivpu: Initial debugfs support > accel/ivpu: Add firmware tracing support > accel/ivpu: Add debugfs files for testing device reset > > drivers/accel/ivpu/Makefile | 4 +- > drivers/accel/ivpu/ivpu_debugfs.c | 294 ++++++++++++++++++++++++++++++ > drivers/accel/ivpu/ivpu_debugfs.h | 13 ++ > drivers/accel/ivpu/ivpu_drv.c | 5 + > drivers/accel/ivpu/ivpu_fw.c | 68 ++++++- > drivers/accel/ivpu/ivpu_fw.h | 4 + > drivers/accel/ivpu/ivpu_fw_log.c | 142 +++++++++++++++ > drivers/accel/ivpu/ivpu_fw_log.h | 38 ++++ > drivers/accel/ivpu/ivpu_pm.c | 1 + > drivers/accel/ivpu/ivpu_pm.h | 1 + > 10 files changed, 563 insertions(+), 7 deletions(-) > create mode 100644 drivers/accel/ivpu/ivpu_debugfs.c > create mode 100644 drivers/accel/ivpu/ivpu_debugfs.h > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.c > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.h > > -- > 2.25.1 >
Hi On Wed, May 24, 2023 at 10:55:08AM +0300, Oded Gabbay wrote: > On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka > <stanislaw.gruszka@linux.intel.com> wrote: > > > > Add debugfs support for ivpu driver, most importantly firmware loging > > and tracing. > Hi, > Without looking at the code I have 2 comments/questions: > > 1. Please add an ABI documentation in Documentation/ABI/testing/ or > Documentation/ABI/stable (if you are feeling courageous). You can see > for example habana's file at > Documentation/ABI/testing/debugfs-driver-habanalabs We do not promise any ABI compatibility for debugfs for ivpu, we can add, remove or modify at any time. Hence make no sense to add documentation files to Documentation/ABI/ for us. > 2. Is this synced with Christian's upcoming changes to the debugfs > infra in drm ? If not, I might suggest to sync with that and wait > until those patches are merged because they change the layout of > debugfs nodes. Is not synced. We can wait before Christian changes get in, what hopefully will happen soon. But if not, ivpu debugfs can be modified along with the changes. I can assist with that. Regards Stanislaw
On Wed, May 24, 2023 at 11:29 AM Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> wrote: > > Hi > > On Wed, May 24, 2023 at 10:55:08AM +0300, Oded Gabbay wrote: > > On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka > > <stanislaw.gruszka@linux.intel.com> wrote: > > > > > > Add debugfs support for ivpu driver, most importantly firmware loging > > > and tracing. > > Hi, > > Without looking at the code I have 2 comments/questions: > > > > 1. Please add an ABI documentation in Documentation/ABI/testing/ or > > Documentation/ABI/stable (if you are feeling courageous). You can see > > for example habana's file at > > Documentation/ABI/testing/debugfs-driver-habanalabs > > We do not promise any ABI compatibility for debugfs for ivpu, > we can add, remove or modify at any time. Hence make no sense to add > documentation files to Documentation/ABI/ for us. ok, I understand that documenting debugfs is not the norm in drm, so I'm not going to change that policy. > > > 2. Is this synced with Christian's upcoming changes to the debugfs > > infra in drm ? If not, I might suggest to sync with that and wait > > until those patches are merged because they change the layout of > > debugfs nodes. > > Is not synced. We can wait before Christian changes get in, what > hopefully will happen soon. But if not, ivpu debugfs can be modified > along with the changes. I can assist with that. I just thought you will prefer to do that, as it will change the layout and then you need to change your s/w stack, but it's up to you ofc. Thanks, Oded > > Regards > Stanislaw >
On Wed, May 24, 2023 at 09:48:42AM +0200, Stanislaw Gruszka wrote: > Add debugfs support for ivpu driver, most importantly firmware loging > and tracing. Applied to drm-misc-next Regards Stanislaw > > Andrzej Kacprowski (1): > accel/ivpu: Print firmware name and version > > Krystian Pradzynski (1): > accel/ivpu: Add fw_name file to debugfs > > Stanislaw Gruszka (3): > accel/ivpu: Initial debugfs support > accel/ivpu: Add firmware tracing support > accel/ivpu: Add debugfs files for testing device reset > > drivers/accel/ivpu/Makefile | 4 +- > drivers/accel/ivpu/ivpu_debugfs.c | 294 ++++++++++++++++++++++++++++++ > drivers/accel/ivpu/ivpu_debugfs.h | 13 ++ > drivers/accel/ivpu/ivpu_drv.c | 5 + > drivers/accel/ivpu/ivpu_fw.c | 68 ++++++- > drivers/accel/ivpu/ivpu_fw.h | 4 + > drivers/accel/ivpu/ivpu_fw_log.c | 142 +++++++++++++++ > drivers/accel/ivpu/ivpu_fw_log.h | 38 ++++ > drivers/accel/ivpu/ivpu_pm.c | 1 + > drivers/accel/ivpu/ivpu_pm.h | 1 + > 10 files changed, 563 insertions(+), 7 deletions(-) > create mode 100644 drivers/accel/ivpu/ivpu_debugfs.c > create mode 100644 drivers/accel/ivpu/ivpu_debugfs.h > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.c > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.h > > -- > 2.25.1 >