| Message ID | 20230706205924.58103-1-shannon.nelson@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3a7af34fb6ecd9fbeb4454fc03c654b26fab5f5e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] ionic: remove dead device fail path | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 6 Jul 2023 13:59:24 -0700 you wrote: > Remove the probe error path code that leaves the driver bound > to the device, but with essentially a dead device. This was > useful maybe twice early in the driver's life and no longer > makes sense to keep. > > Fixes: 30a1e6d0f8e2 ("ionic: keep ionic dev on lif init fail") > Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> > > [...] Here is the summary with links: - [net] ionic: remove dead device fail path https://git.kernel.org/netdev/net/c/3a7af34fb6ec You are awesome, thank you!
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c index b8678da1cce5..ab7d217b98b3 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c @@ -353,12 +353,6 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ionic_reset(ionic); err_out_teardown: ionic_dev_teardown(ionic); - pci_clear_master(pdev); - /* Don't fail the probe for these errors, keep - * the hw interface around for inspection - */ - return 0; - err_out_unmap_bars: ionic_unmap_bars(ionic); err_out_pci_release_regions:
Remove the probe error path code that leaves the driver bound to the device, but with essentially a dead device. This was useful maybe twice early in the driver's life and no longer makes sense to keep. Fixes: 30a1e6d0f8e2 ("ionic: keep ionic dev on lif init fail") Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> --- drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 6 ------ 1 file changed, 6 deletions(-)