| Message ID | 20230707060501.29184-1-liuq131@chinatelecom.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/sparse: remove redundant judgments from macro for_each_present_section_nr | expand |
> The next_present_section_nr function has already ensured > that 'section_nr<=__highest_present_section_nr', > so this conditional judgment is removed. Please choose an imperative change suggestion. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 > Signed-off-by: liuq <liuq131@chinatelecom.cn> Would a more unique real name be more appropriate here? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n411 Regards, Markus
diff --git a/mm/sparse.c b/mm/sparse.c index 297a8b772e8d..77d91e565045 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -172,8 +172,7 @@ static void __section_mark_present(struct mem_section *ms, #define for_each_present_section_nr(start, section_nr) \ for (section_nr = next_present_section_nr(start-1); \ - ((section_nr != -1) && \ - (section_nr <= __highest_present_section_nr)); \ + section_nr != -1; \ section_nr = next_present_section_nr(section_nr)) static inline unsigned long first_present_section_nr(void)
The next_present_section_nr function has already ensured that 'section_nr<=__highest_present_section_nr', so this conditional judgment is removed. Signed-off-by: liuq <liuq131@chinatelecom.cn> --- mm/sparse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)