| Message ID | 20230710100830.89936-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b8e39b38487e68c6503419db6e4a851a0ef56de7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,resend,v1,1/2] net/core: Make use of assign_bit() API | expand |
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Mon, 10 Jul 2023 13:08:30 +0300 > We have for some time the __assign_bit() API to replace open coded > > if (foo) > __set_bit(n, bar); > else > __clear_bit(n, bar); > > Use this API in the code. No functional change intended. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com> Thanks, Olek
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index d81e7a43944c..81e4b802f3f9 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1630,10 +1630,7 @@ static void netlink_update_socket_mc(struct netlink_sock *nlk, old = test_bit(group - 1, nlk->groups); subscriptions = nlk->subscriptions - old + new; - if (new) - __set_bit(group - 1, nlk->groups); - else - __clear_bit(group - 1, nlk->groups); + __assign_bit(group - 1, nlk->groups, new); netlink_update_subscriptions(&nlk->sk, subscriptions); netlink_update_listeners(&nlk->sk); }
We have for some time the __assign_bit() API to replace open coded if (foo) __set_bit(n, bar); else __clear_bit(n, bar); Use this API in the code. No functional change intended. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- net/netlink/af_netlink.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)