| Message ID | 1689054169-10800-3-git-send-email-quic_rohiagar@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add rpmhpd support for SDX75 | expand |
On 11/07/2023 07:42, Rohit Agarwal wrote: > Add a compatible string that can be used to list PDs for sdx75. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 11/07/2023 07:53, Krzysztof Kozlowski wrote: > On 11/07/2023 07:42, Rohit Agarwal wrote: >> Add a compatible string that can be used to list PDs for sdx75. >> >> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >> --- > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Ah, I forgot: you miss device name in subject prefixes. You do not add here sdx75 to all power bindings, do you? This applies to all your patches and commits. Best regards, Krzysztof
On 7/11/2023 11:25 AM, Krzysztof Kozlowski wrote: > On 11/07/2023 07:53, Krzysztof Kozlowski wrote: >> On 11/07/2023 07:42, Rohit Agarwal wrote: >>> Add a compatible string that can be used to list PDs for sdx75. >>> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>> --- >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> > Ah, I forgot: you miss device name in subject prefixes. You do not add > here sdx75 to all power bindings, do you? This applies to all your > patches and commits. Do you mean I need to update the subject as this? dt-bindings: power: sdx75: Add compatible for sdx75 Thanks, Rohit. > Best regards, > Krzysztof >
On 11/07/2023 08:20, Rohit Agarwal wrote: > > On 7/11/2023 11:25 AM, Krzysztof Kozlowski wrote: >> On 11/07/2023 07:53, Krzysztof Kozlowski wrote: >>> On 11/07/2023 07:42, Rohit Agarwal wrote: >>>> Add a compatible string that can be used to list PDs for sdx75. >>>> >>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>> --- >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >> Ah, I forgot: you miss device name in subject prefixes. You do not add >> here sdx75 to all power bindings, do you? This applies to all your >> patches and commits. > Do you mean I need to update the subject as this? > > dt-bindings: power: sdx75: Add compatible for sdx75 No, the device binding is qcom,rpmpd. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml index f9c211a..9b03c41 100644 --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml @@ -41,6 +41,7 @@ properties: - qcom,sdm845-rpmhpd - qcom,sdx55-rpmhpd - qcom,sdx65-rpmhpd + - qcom,sdx75-rpmhpd - qcom,sm6115-rpmpd - qcom,sm6125-rpmpd - qcom,sm6350-rpmhpd
Add a compatible string that can be used to list PDs for sdx75. Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> --- Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + 1 file changed, 1 insertion(+)