Message ID | 20230711063011.16222-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
---|---|
State | Accepted |
Commit | b8fbeea0253211d97c579eae787274633d3eaf0d |
Headers | show |
Series | arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again | expand |
On 11.07.2023 08:30, Krzysztof Kozlowski wrote: > gpio-keys,wakeup is a deprecated property: > > m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected) > > Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > It's a damn Groundhog day. I already fixed all the occurences in > 77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys > wakeup")! > --- Sorry.. this was an old lingering patch that I failed to retest. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > index cd27794739a5..ecdc20bc10f5 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > @@ -60,7 +60,7 @@ key-camera-focus { > gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>; > debounce-interval = <15>; > linux,can-disable; > - gpio-key,wakeup; > + wakeup-source; > }; > > key-camera-snapshot { > @@ -69,7 +69,7 @@ key-camera-snapshot { > gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>; > debounce-interval = <15>; > linux,can-disable; > - gpio-key,wakeup; > + wakeup-source; > }; > > key-vol-down {
On Tue, 11 Jul 2023 08:30:11 +0200, Krzysztof Kozlowski wrote: > gpio-keys,wakeup is a deprecated property: > > m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected) > > Applied, thanks! [1/1] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again commit: b8fbeea0253211d97c579eae787274633d3eaf0d Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi index cd27794739a5..ecdc20bc10f5 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi @@ -60,7 +60,7 @@ key-camera-focus { gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>; debounce-interval = <15>; linux,can-disable; - gpio-key,wakeup; + wakeup-source; }; key-camera-snapshot { @@ -69,7 +69,7 @@ key-camera-snapshot { gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>; debounce-interval = <15>; linux,can-disable; - gpio-key,wakeup; + wakeup-source; }; key-vol-down {
gpio-keys,wakeup is a deprecated property: m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected) Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- It's a damn Groundhog day. I already fixed all the occurences in 77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup")! --- arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)