| Message ID | 20230711-startek_display-v1-1-163917bed385@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add startek-kd070fhfid015 display support | expand |
On Tue, Jul 11, 2023 at 05:36:27PM +0200, Alexandre Mergnat wrote: > The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution > of 1024 x 600 pixels. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../display/panel/startek,kd070fhfid015.yaml | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml > new file mode 100644 > index 000000000000..857658e002fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/startek,kd070fhfid015.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Startek Electronic Technology Co. kd070fhfid015 7 inch TFT LCD panel > + > +maintainers: > + - Alexandre Mergnat <amergnat@baylibre.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: startek,kd070fhfid015 > + > + dcdc-gpios: true > + > + height-mm: > + const: 151 Are height-mm and width-mm useful if they are always a fixed value? Otherwise, it looks grand to me, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > + > + iovcc-supply: > + description: Reference to the regulator powering the panel IO pins. > + > + reg: > + maxItems: 1 > + description: DSI virtual channel nit: usually reg gets sorted after compatible, even if everything else is in alphabetical order, but hardly important.
On 11/07/2023 17:36, Alexandre Mergnat wrote: > The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution > of 1024 x 600 pixels. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../display/panel/startek,kd070fhfid015.yaml | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml > new file mode 100644 > index 000000000000..857658e002fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/startek,kd070fhfid015.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Startek Electronic Technology Co. kd070fhfid015 7 inch TFT LCD panel > + > +maintainers: > + - Alexandre Mergnat <amergnat@baylibre.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: startek,kd070fhfid015 > + > + dcdc-gpios: true From where does this come? Which schema defines it? > + > + height-mm: > + const: 151 > + > + iovcc-supply: > + description: Reference to the regulator powering the panel IO pins. > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + reset-gpios: true > + > + port: true > + > + power-supply: true > + > + width-mm: > + const: 95 > + > +additionalProperties: false > + > +required: > + - compatible > + - dcdc-gpios > + - iovcc-supply > + - reg > + - reset-gpios > + - port > + - power-supply Missing example. Best regards, Krzysztof
Hi Krzysztof, Thanks for your review On 12/07/2023 07:32, Krzysztof Kozlowski wrote: > On 11/07/2023 17:36, Alexandre Mergnat wrote: >> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution snip >> + >> + dcdc-gpios: true > > From where does this come? Which schema defines it? It's a miss. I will fix it and reset-gpios too by adding a maxItems and a description. >> + >> + height-mm: >> + const: 151 >> + >> + iovcc-supply: >> + description: Reference to the regulator powering the panel IO pins. >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + reset-gpios: true >> + >> + port: true >> + >> + power-supply: true >> + >> + width-mm: >> + const: 95 >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - dcdc-gpios >> + - iovcc-supply >> + - reg >> + - reset-gpios >> + - port >> + - power-supply > > Missing example. I will add it.
On 12/07/2023 10:01, Alexandre Mergnat wrote: > Hi Krzysztof, > > Thanks for your review > > On 12/07/2023 07:32, Krzysztof Kozlowski wrote: >> On 11/07/2023 17:36, Alexandre Mergnat wrote: >>> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution > > snip > >>> + >>> + dcdc-gpios: true >> >> From where does this come? Which schema defines it? > > It's a miss. I will fix it and reset-gpios too by adding a maxItems and > a description. reset-gpios come from panel-common, so they are fine. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml new file mode 100644 index 000000000000..857658e002fd --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/startek,kd070fhfid015.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Startek Electronic Technology Co. kd070fhfid015 7 inch TFT LCD panel + +maintainers: + - Alexandre Mergnat <amergnat@baylibre.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: startek,kd070fhfid015 + + dcdc-gpios: true + + height-mm: + const: 151 + + iovcc-supply: + description: Reference to the regulator powering the panel IO pins. + + reg: + maxItems: 1 + description: DSI virtual channel + + reset-gpios: true + + port: true + + power-supply: true + + width-mm: + const: 95 + +additionalProperties: false + +required: + - compatible + - dcdc-gpios + - iovcc-supply + - reg + - reset-gpios + - port + - power-supply + +...
The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- .../display/panel/startek,kd070fhfid015.yaml | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+)