[v9,00/33] scsi: Allow scsi_execute users to control retries

Message

Mike Christie July 11, 2023, 9:45 p.m. UTC

The following patches were made over Martin's 6.6 scsi-queue branch.
They allow scsi_execute_cmd users to control exactly which errors are
retried, so we can reduce the sense/sshd handling they have to do and
have it one place.

The patches allow scsi_execute_cmd users to pass in an array of failures
which they want retried/failed and also specify how many times they want
them retried. If we hit an error that the user did not specify then we drop
down to the default behavior. This allows us to remove almost all the
retry logic from scsi_execute_cmd users. We just have the special cases
where we want to retry with a difference size command or sleep between
retries.

v9:
- Drop spi_execute changes from [PATCH] scsi: spi: Fix sshdr use
- Change git commit message for sshdr use fixes to try and make it
more clear when we need to check and when we can check.

v8:
- Rebase.
- Saw the discussion about the possible bug where callers are
accessing the sshdr when it's not setup, so I added some patches
for that since I was going over the same code.

v7:
- Rebase against scsi_execute_cmd patchset.

v6:
- Fix kunit build when it's built as a module but scsi is not.
- Drop [PATCH 17/35] scsi: ufshcd: Convert to scsi_exec_req because
  that driver no longer uses scsi_execute.
- Convert ufshcd to use the scsi_failures struct because it now just does
  direct retries and does not do it's own deadline timing.
- Add back memset in read_capacity_16.
- Remove memset in get_sectorsize and replace with { } to init buf.

v5:
- Fix spelling (made sure I ran checkpatch strict)
- Drop SCMD_FAILURE_NONE
- Rename SCMD_FAILURE_ANY
- Fix media_not_present handling where it was being retried instead of
failed.
- Fix ILLEGAL_REQUEST handling in read_capacity_16 so it was not retried.
- Fix coding style, spelling and and naming convention in kunit and added
  more tests to handle cases like the media_not_present one where we want
  to force failures instead of retries.
- Drop cxlflash patch because it actually checked it's internal state before
  performing a retry which we currently do not support.

v4:
- Redefine cmd definitions if the cmd is touched.
- Fix up coding style issues.
- Use sam_status enum.
- Move failures initialization to scsi_initialize_rq
(also fixes KASAN error).
- Add kunit test.
- Add function comments.

v3:
- Use a for loop in scsi_check_passthrough
- Fix result handling/testing.
- Fix scsi_status_is_good handling.
- make __scsi_exec_req take a const arg
- Fix formatting in patch 24

v2:
- Rename scsi_prep_sense
- Change scsi_check_passthrough's loop and added some fixes
- Modified scsi_execute* so it uses a struct to pass in args

Comments

Mike Christie July 11, 2023, 9:50 p.m. UTC | #1

I'm sorry to have to spam the list. While sending this patchset
outlook started to return failures on me, so only patches 0 -24
got sent.

I'm going to look into it, and will resend this patchset when I
figure out what happened.

On 7/11/23 4:45 PM, Mike Christie wrote:
> The following patches were made over Martin's 6.6 scsi-queue branch.
> They allow scsi_execute_cmd users to control exactly which errors are
> retried, so we can reduce the sense/sshd handling they have to do and
> have it one place.
> 
> The patches allow scsi_execute_cmd users to pass in an array of failures
> which they want retried/failed and also specify how many times they want
> them retried. If we hit an error that the user did not specify then we drop
> down to the default behavior. This allows us to remove almost all the
> retry logic from scsi_execute_cmd users. We just have the special cases
> where we want to retry with a difference size command or sleep between
> retries.