mbox series

[net-next,v3,00/12] net: stmmac: replace boolean fields in plat_stmmacenet_data with flags

Message ID 20230710090001.303225-1-brgl@bgdev.pl (mailing list archive)
Headers show
Series net: stmmac: replace boolean fields in plat_stmmacenet_data with flags | expand

Message

Bartosz Golaszewski July 10, 2023, 8:59 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

As suggested by Jose Abreu: let's drop all 12 boolean fields in
plat_stmmacenet_data and replace them with a common bitfield.

v2 -> v3:
- fix build on intel platforms even more
- collect review tags from Andrew

v1 -> v2:
- fix build on intel platforms

Bartosz Golaszewski (12):
  net: stmmac: replace the has_integrated_pcs field with a flag
  net: stmmac: replace the sph_disable field with a flag
  net: stmmac: replace the use_phy_wol field with a flag
  net: stmmac: replace the has_sun8i field with a flag
  net: stmmac: replace the tso_en field with a flag
  net: stmmac: replace the serdes_up_after_phy_linkup field with a flag
  net: stmmac: replace the vlan_fail_q_en field with a flag
  net: stmmac: replace the multi_msi_en field with a flag
  net: stmmac: replace the ext_snapshot_en field with a flag
  net: stmmac: replace the int_snapshot_en field with a flag
  net: stmmac: replace the rx_clk_runs_in_lpi field with a flag
  net: stmmac: replace the en_tx_lpi_clockgating field with a flag

 .../stmicro/stmmac/dwmac-dwc-qos-eth.c        |  4 +-
 .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 23 +++++------
 .../ethernet/stmicro/stmmac/dwmac-mediatek.c  |  5 ++-
 .../stmicro/stmmac/dwmac-qcom-ethqos.c        |  8 ++--
 .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c |  2 +-
 .../net/ethernet/stmicro/stmmac/dwmac-tegra.c |  4 +-
 .../ethernet/stmicro/stmmac/stmmac_hwtstamp.c |  4 +-
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 40 +++++++++++--------
 .../net/ethernet/stmicro/stmmac/stmmac_pci.c  |  2 +-
 .../ethernet/stmicro/stmmac/stmmac_platform.c | 10 +++--
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  5 ++-
 include/linux/stmmac.h                        | 26 ++++++------
 12 files changed, 76 insertions(+), 57 deletions(-)

Comments

Jakub Kicinski July 12, 2023, 3:21 a.m. UTC | #1
On Mon, 10 Jul 2023 10:59:49 +0200 Bartosz Golaszewski wrote:
> As suggested by Jose Abreu: let's drop all 12 boolean fields in
> plat_stmmacenet_data and replace them with a common bitfield.

Peppe, please take a look.
Simon Horman July 13, 2023, 10:11 a.m. UTC | #2
On Mon, Jul 10, 2023 at 10:59:49AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> As suggested by Jose Abreu: let's drop all 12 boolean fields in
> plat_stmmacenet_data and replace them with a common bitfield.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
patchwork-bot+netdevbpf@kernel.org July 14, 2023, 4 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 10 Jul 2023 10:59:49 +0200 you wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> As suggested by Jose Abreu: let's drop all 12 boolean fields in
> plat_stmmacenet_data and replace them with a common bitfield.
> 
> v2 -> v3:
> - fix build on intel platforms even more
> - collect review tags from Andrew
> 
> [...]

Here is the summary with links:
  - [net-next,v3,01/12] net: stmmac: replace the has_integrated_pcs field with a flag
    https://git.kernel.org/netdev/net-next/c/d26979f1cef7
  - [net-next,v3,02/12] net: stmmac: replace the sph_disable field with a flag
    https://git.kernel.org/netdev/net-next/c/309efe6eb499
  - [net-next,v3,03/12] net: stmmac: replace the use_phy_wol field with a flag
    https://git.kernel.org/netdev/net-next/c/fd1d62d80ebc
  - [net-next,v3,04/12] net: stmmac: replace the has_sun8i field with a flag
    https://git.kernel.org/netdev/net-next/c/d8daff284e30
  - [net-next,v3,05/12] net: stmmac: replace the tso_en field with a flag
    https://git.kernel.org/netdev/net-next/c/68861a3bcc1c
  - [net-next,v3,06/12] net: stmmac: replace the serdes_up_after_phy_linkup field with a flag
    https://git.kernel.org/netdev/net-next/c/efe92571bfc3
  - [net-next,v3,07/12] net: stmmac: replace the vlan_fail_q_en field with a flag
    https://git.kernel.org/netdev/net-next/c/fc02152bdbb2
  - [net-next,v3,08/12] net: stmmac: replace the multi_msi_en field with a flag
    https://git.kernel.org/netdev/net-next/c/956c3f09b9c4
  - [net-next,v3,09/12] net: stmmac: replace the ext_snapshot_en field with a flag
    https://git.kernel.org/netdev/net-next/c/aa5513f5d95f
  - [net-next,v3,10/12] net: stmmac: replace the int_snapshot_en field with a flag
    https://git.kernel.org/netdev/net-next/c/621ba7ad7891
  - [net-next,v3,11/12] net: stmmac: replace the rx_clk_runs_in_lpi field with a flag
    https://git.kernel.org/netdev/net-next/c/743dd1db85f4
  - [net-next,v3,12/12] net: stmmac: replace the en_tx_lpi_clockgating field with a flag
    https://git.kernel.org/netdev/net-next/c/9d0c0d5ebd63

You are awesome, thank you!