| Message ID | 20230412115250.164899-2-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: Small mtk-dpi cleanups | expand |
Hi Angelo, On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Change drm_bridge_add() to its devm variant to slightly simplify the > probe function. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 948a53f1f4b3..2d5f3fc34f61 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct platform_device *pdev) > dpi->bridge.of_node = dev->of_node; > dpi->bridge.type = DRM_MODE_CONNECTOR_DPI; > > - drm_bridge_add(&dpi->bridge); > + ret = devm_drm_bridge_add(dev, &dpi->bridge); > + if (ret) > + return ret; And also drop the drm_bridge_remove() call in mtk_dpi_remove()? Regards, Fei > > ret = component_add(dev, &mtk_dpi_component_ops); > if (ret) { > - drm_bridge_remove(&dpi->bridge); > dev_err(dev, "Failed to add component: %d\n", ret); > return ret; > } > -- > 2.40.0 > >
Il 13/07/23 09:55, Fei Shao ha scritto: > Hi Angelo, > > On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Change drm_bridge_add() to its devm variant to slightly simplify the >> probe function. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> drivers/gpu/drm/mediatek/mtk_dpi.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c >> index 948a53f1f4b3..2d5f3fc34f61 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c >> @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct platform_device *pdev) >> dpi->bridge.of_node = dev->of_node; >> dpi->bridge.type = DRM_MODE_CONNECTOR_DPI; >> >> - drm_bridge_add(&dpi->bridge); >> + ret = devm_drm_bridge_add(dev, &dpi->bridge); >> + if (ret) >> + return ret; > > And also drop the drm_bridge_remove() call in mtk_dpi_remove()? > Yes. V2 will drop that. Cheers, Angelo > Regards, > Fei > >> >> ret = component_add(dev, &mtk_dpi_component_ops); >> if (ret) { >> - drm_bridge_remove(&dpi->bridge); >> dev_err(dev, "Failed to add component: %d\n", ret); >> return ret; >> } >> -- >> 2.40.0 >> >> >
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 948a53f1f4b3..2d5f3fc34f61 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct platform_device *pdev) dpi->bridge.of_node = dev->of_node; dpi->bridge.type = DRM_MODE_CONNECTOR_DPI; - drm_bridge_add(&dpi->bridge); + ret = devm_drm_bridge_add(dev, &dpi->bridge); + if (ret) + return ret; ret = component_add(dev, &mtk_dpi_component_ops); if (ret) { - drm_bridge_remove(&dpi->bridge); dev_err(dev, "Failed to add component: %d\n", ret); return ret; }
Change drm_bridge_add() to its devm variant to slightly simplify the probe function. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)