[v5,0/2] spi-geni-qcom: Add SPI device mode support for GENI based QuPv3

Message

Praveen Talari July 7, 2023, 5:16 a.m. UTC

This series adds spi device mode functionality to geni based Qupv3.
The common header file contains spi slave related registers and masks.

Praveen Talari (2):
  soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
  spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
---
v4 -> v5:
- Addressed review comments in driver

v3 -> v4:
- Used existing property spi-slave
- Hence dropped dt-binding changes

v2 -> v3:
- Modified commit message
- Addressed comment on dt-binding

v1 -> v2:
- Added dt-binding change for spi slave
- Modified commit message
- Addressed review comments in driver

 drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
 include/linux/soc/qcom/geni-se.h |  9 ++++++
 2 files changed, 56 insertions(+), 6 deletions(-)

Comments

Konrad Dybcio July 7, 2023, 12:29 p.m. UTC | #1

On 7.07.2023 07:16, Praveen Talari wrote:
> This series adds spi device mode functionality to geni based Qupv3.
> The common header file contains spi slave related registers and masks.
> 
> Praveen Talari (2):
>   soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
>   spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
> ---
> v4 -> v5:
> - Addressed review comments in driver
"fix bug" says exactly nothing

Konrad
> 
> v3 -> v4:
> - Used existing property spi-slave
> - Hence dropped dt-binding changes
> 
> v2 -> v3:
> - Modified commit message
> - Addressed comment on dt-binding
> 
> v1 -> v2:
> - Added dt-binding change for spi slave
> - Modified commit message
> - Addressed review comments in driver
> 
>  drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
>  include/linux/soc/qcom/geni-se.h |  9 ++++++
>  2 files changed, 56 insertions(+), 6 deletions(-)
>

Praveen Talari July 13, 2023, 11:54 a.m. UTC | #2

Hi

On 7/7/2023 5:59 PM, Konrad Dybcio wrote:
> On 7.07.2023 07:16, Praveen Talari wrote:
>> This series adds spi device mode functionality to geni based Qupv3.
>> The common header file contains spi slave related registers and masks.
>>
>> Praveen Talari (2):
>>    soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
>>    spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
>> ---
>> v4 -> v5:
>> - Addressed review comments in driver
> "fix bug" says exactly nothing
Addressed
>
> Konrad
>> v3 -> v4:
>> - Used existing property spi-slave
>> - Hence dropped dt-binding changes
>>
>> v2 -> v3:
>> - Modified commit message
>> - Addressed comment on dt-binding
>>
>> v1 -> v2:
>> - Added dt-binding change for spi slave
>> - Modified commit message
>> - Addressed review comments in driver
>>
>>   drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
>>   include/linux/soc/qcom/geni-se.h |  9 ++++++
>>   2 files changed, 56 insertions(+), 6 deletions(-)
>>