| Message ID | 20230714075155.5686-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags | expand |
Hi Thomas, On Fri, Jul 14, 2023 at 9:53 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: > Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from > fbdev and drivers, as briefly discussed at [1]. Both flags were maybe > useful when fbdev had special handling for driver modules. With > commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 > and have no further effect. > > Patches 1 to 7 remove FBINFO_DEFAULT from drivers. Patches 2 to 5 > split this by the way the fb_info struct is being allocated. All flags > are cleared to zero during the allocation. > > Patches 8 to 16 do the same for FBINFO_FLAG_DEFAULT. Patch 8 fixes > an actual bug in how arch/sh uses the token for struct fb_videomode, > which is unrelated. > > Patch 17 removes both flag constants from <linux/fb.h> and patch 18 > documents the zero'ed memory returned by framebuffer_alloc(). > > v3: > * sh: include board name in commit message (Adrian) > * docs: reword text (Miguel) Thanks for the update! > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Four patches with the exact same one-line summary. Please make them unique. > fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers > fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Two patches with the exact same one-line summary. Please make them unique. Gr{oetje,eeting}s, Geert
Hi Am 14.07.23 um 12:04 schrieb Geert Uytterhoeven: > Hi Thomas, > > On Fri, Jul 14, 2023 at 9:53 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: >> Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from >> fbdev and drivers, as briefly discussed at [1]. Both flags were maybe >> useful when fbdev had special handling for driver modules. With >> commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 >> and have no further effect. >> >> Patches 1 to 7 remove FBINFO_DEFAULT from drivers. Patches 2 to 5 >> split this by the way the fb_info struct is being allocated. All flags >> are cleared to zero during the allocation. >> >> Patches 8 to 16 do the same for FBINFO_FLAG_DEFAULT. Patch 8 fixes >> an actual bug in how arch/sh uses the token for struct fb_videomode, >> which is unrelated. >> >> Patch 17 removes both flag constants from <linux/fb.h> and patch 18 >> documents the zero'ed memory returned by framebuffer_alloc(). >> >> v3: >> * sh: include board name in commit message (Adrian) >> * docs: reword text (Miguel) > > Thanks for the update! > >> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers I wasn't happy about this either. But I could not come up with a description that fits into the 74-char limit for each commit. They only differ in the method of memory allocation. Do you have any ideas? > > Four patches with the exact same one-line summary. Please make them > unique. > >> fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers >> fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers > > Two patches with the exact same one-line summary. Please make them > unique. Same problem here. Best regards Thomas > > Gr{oetje,eeting}s, > > Geert >
On Fri, Jul 14, 2023 at 12:24:05PM +0200, Thomas Zimmermann wrote: > > > > > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > > > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > > > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > > > fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers > > > I wasn't happy about this either. But I could not come up with a description > that fits into the 74-char limit for each commit. They only differ in the > method of memory allocation. Do you have any ideas? fbdev: Remove FBINFO_DEFAULT from static structs fbdev: Remove FBINFO_DEFAULT from kzalloc() structs fbdev: Remove FBINFO_DEFAULT from devm_kzalloc() structs regards, dan carpenter
Hi Am 14.07.23 um 12:29 schrieb Dan Carpenter: > On Fri, Jul 14, 2023 at 12:24:05PM +0200, Thomas Zimmermann wrote: >>> >>>> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >>>> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >>>> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >>>> fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers >> >> >> I wasn't happy about this either. But I could not come up with a description >> that fits into the 74-char limit for each commit. They only differ in the >> method of memory allocation. Do you have any ideas? > > fbdev: Remove FBINFO_DEFAULT from static structs > fbdev: Remove FBINFO_DEFAULT from kzalloc() structs > fbdev: Remove FBINFO_DEFAULT from devm_kzalloc() structs Sounds good, I'll use that. Thanks! Best regards Thomas > > regards, > dan carpenter >
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from fbdev and drivers, as briefly discussed at [1]. Both flags were maybe useful when fbdev had special handling for driver modules. With commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 and have no further effect. Patches 1 to 7 remove FBINFO_DEFAULT from drivers. Patches 2 to 5 split this by the way the fb_info struct is being allocated. All flags are cleared to zero during the allocation. Patches 8 to 16 do the same for FBINFO_FLAG_DEFAULT. Patch 8 fixes an actual bug in how arch/sh uses the token for struct fb_videomode, which is unrelated. Patch 17 removes both flag constants from <linux/fb.h> and patch 18 documents the zero'ed memory returned by framebuffer_alloc(). v3: * sh: include board name in commit message (Adrian) * docs: reword text (Miguel) v2: * sh: use FB_MODE_IS_UNKNOWN (Adrian) * fix commit messages (Miguel) * document framebuffer_alloc()'s zero'ed memory (Miguel) [1] https://lore.kernel.org/dri-devel/877crer8fm.fsf@minerva.mail-host-address-is-not-set/ Thomas Zimmermann (18): drm: Remove flag FBINFO_DEFAULT from fbdev emulation fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT fbdev: Document that framebuffer_alloc() returns zero'ed data arch/sh/boards/mach-sh7763rdp/setup.c | 2 +- drivers/auxdisplay/cfag12864bfb.c | 1 - drivers/auxdisplay/ht16k33.c | 1 - drivers/gpu/drm/drm_fbdev_dma.c | 1 - drivers/gpu/drm/drm_fbdev_generic.c | 1 - drivers/gpu/drm/gma500/fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fbdev.c | 2 +- drivers/hid/hid-picolcd_fb.c | 1 - drivers/media/pci/ivtv/ivtvfb.c | 1 - drivers/media/test-drivers/vivid/vivid-osd.c | 1 - drivers/staging/fbtft/fbtft-core.c | 2 +- drivers/staging/sm750fb/sm750.c | 1 - drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +- drivers/video/fbdev/amba-clcd.c | 1 - drivers/video/fbdev/amifb.c | 5 ++--- drivers/video/fbdev/arcfb.c | 1 - drivers/video/fbdev/asiliantfb.c | 1 - drivers/video/fbdev/atafb.c | 1 - drivers/video/fbdev/atmel_lcdfb.c | 2 +- drivers/video/fbdev/aty/aty128fb.c | 1 - drivers/video/fbdev/aty/atyfb_base.c | 3 +-- drivers/video/fbdev/aty/radeon_base.c | 3 +-- drivers/video/fbdev/broadsheetfb.c | 2 +- drivers/video/fbdev/bw2.c | 1 - drivers/video/fbdev/carminefb.c | 1 - drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 1 - drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/chipsfb.c | 1 - drivers/video/fbdev/cirrusfb.c | 3 +-- drivers/video/fbdev/clps711x-fb.c | 1 - drivers/video/fbdev/cobalt_lcdfb.c | 1 - drivers/video/fbdev/controlfb.c | 2 +- drivers/video/fbdev/core/fb_info.c | 3 ++- drivers/video/fbdev/cyber2000fb.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 1 - drivers/video/fbdev/efifb.c | 1 - drivers/video/fbdev/ep93xx-fb.c | 1 - drivers/video/fbdev/ffb.c | 3 +-- drivers/video/fbdev/fm2fb.c | 1 - drivers/video/fbdev/fsl-diu-fb.c | 2 +- drivers/video/fbdev/g364fb.c | 2 +- drivers/video/fbdev/gbefb.c | 1 - drivers/video/fbdev/geode/gx1fb_core.c | 1 - drivers/video/fbdev/geode/gxfb_core.c | 1 - drivers/video/fbdev/geode/lxfb_core.c | 1 - drivers/video/fbdev/goldfishfb.c | 1 - drivers/video/fbdev/grvga.c | 2 +- drivers/video/fbdev/gxt4500.c | 3 +-- drivers/video/fbdev/hecubafb.c | 2 +- drivers/video/fbdev/hgafb.c | 2 +- drivers/video/fbdev/hitfb.c | 2 +- drivers/video/fbdev/hpfb.c | 1 - drivers/video/fbdev/hyperv_fb.c | 2 -- drivers/video/fbdev/i740fb.c | 2 +- drivers/video/fbdev/i810/i810_main.c | 4 ++-- drivers/video/fbdev/imsttfb.c | 3 +-- drivers/video/fbdev/imxfb.c | 3 +-- drivers/video/fbdev/intelfb/intelfbdrv.c | 5 ++--- drivers/video/fbdev/kyro/fbdev.c | 1 - drivers/video/fbdev/leo.c | 1 - drivers/video/fbdev/macfb.c | 1 - drivers/video/fbdev/matrox/matroxfb_crtc2.c | 5 ++--- drivers/video/fbdev/maxinefb.c | 1 - drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- drivers/video/fbdev/metronomefb.c | 2 +- drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- drivers/video/fbdev/mx3fb.c | 1 - drivers/video/fbdev/neofb.c | 2 +- drivers/video/fbdev/nvidia/nvidia.c | 4 ++-- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/omap/omapfb_main.c | 1 - drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 - drivers/video/fbdev/p9100.c | 1 - drivers/video/fbdev/platinumfb.c | 1 - drivers/video/fbdev/pm2fb.c | 3 +-- drivers/video/fbdev/pm3fb.c | 3 +-- drivers/video/fbdev/pmag-aa-fb.c | 1 - drivers/video/fbdev/pmag-ba-fb.c | 1 - drivers/video/fbdev/pmagb-b-fb.c | 1 - drivers/video/fbdev/ps3fb.c | 2 +- drivers/video/fbdev/pvr2fb.c | 2 +- drivers/video/fbdev/pxa168fb.c | 2 +- drivers/video/fbdev/pxafb.c | 2 -- drivers/video/fbdev/q40fb.c | 1 - drivers/video/fbdev/riva/fbdev.c | 3 +-- drivers/video/fbdev/s1d13xxxfb.c | 4 ++-- drivers/video/fbdev/s3c-fb.c | 1 - drivers/video/fbdev/sa1100fb.c | 1 - drivers/video/fbdev/savage/savagefb_driver.c | 3 +-- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 -- drivers/video/fbdev/simplefb.c | 1 - drivers/video/fbdev/sis/sis_main.c | 5 +---- drivers/video/fbdev/skeletonfb.c | 2 +- drivers/video/fbdev/sm501fb.c | 2 +- drivers/video/fbdev/sm712fb.c | 1 - drivers/video/fbdev/smscufx.c | 2 +- drivers/video/fbdev/sstfb.c | 1 - drivers/video/fbdev/sunxvr1000.c | 1 - drivers/video/fbdev/sunxvr2500.c | 1 - drivers/video/fbdev/sunxvr500.c | 1 - drivers/video/fbdev/tcx.c | 1 - drivers/video/fbdev/tdfxfb.c | 2 +- drivers/video/fbdev/tgafb.c | 2 +- drivers/video/fbdev/tridentfb.c | 2 +- drivers/video/fbdev/udlfb.c | 2 +- drivers/video/fbdev/uvesafb.c | 3 +-- drivers/video/fbdev/valkyriefb.c | 1 - drivers/video/fbdev/vermilion/vermilion.c | 2 +- drivers/video/fbdev/vesafb.c | 2 +- drivers/video/fbdev/vfb.c | 1 - drivers/video/fbdev/vga16fb.c | 2 +- drivers/video/fbdev/via/viafbdev.c | 2 +- drivers/video/fbdev/vt8500lcdfb.c | 3 +-- drivers/video/fbdev/wm8505fb.c | 3 +-- drivers/video/fbdev/xen-fbfront.c | 2 +- drivers/video/fbdev/xilinxfb.c | 1 - include/linux/fb.h | 3 --- samples/vfio-mdev/mdpy-fb.c | 1 - 120 files changed, 68 insertions(+), 151 deletions(-)