| Message ID | ZLD8RkrgU/A9pZMf@lenoch (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Cleanup Octeon DWC3 glue code | expand |
On Fri, Jul 14, 2023, Ladislav Michl wrote: > From: Ladislav Michl <ladis@linux-mips.org> > > As driver is rewritten and David no longer works for Marvell (Cavium), > I'm to blame for breakage. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > --- > CHANGES: > - v2: None > - v3: None > > drivers/usb/dwc3/dwc3-octeon.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c > index dd47498f4efb..a68d568b11a9 100644 > --- a/drivers/usb/dwc3/dwc3-octeon.c > +++ b/drivers/usb/dwc3/dwc3-octeon.c > @@ -1,11 +1,9 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > - * XHCI HCD glue for Cavium Octeon III SOCs. > + * DWC3 glue for Cavium Octeon III SOCs. > * > * Copyright (C) 2010-2017 Cavium Networks > - * > - * This file is subject to the terms and conditions of the GNU General Public > - * License. See the file "COPYING" in the main directory of this archive > - * for more details. > + * Copyright (C) 2023 Ladislav Michl <ladis@linux-mips.org> I may not be an expert with Copyright, but is it correct to put your name rather than the entity this belongs to? BR, Thinh > */ > > #include <linux/bitfield.h> > @@ -536,6 +534,6 @@ static struct platform_driver dwc3_octeon_driver = { > module_platform_driver(dwc3_octeon_driver); > > MODULE_ALIAS("platform:dwc3-octeon"); > -MODULE_AUTHOR("David Daney <david.daney@cavium.com>"); > +MODULE_AUTHOR("Ladislav Michl <ladis@linux-mips.org>"); > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("DesignWare USB3 OCTEON III Glue Layer"); > -- > 2.39.2 >
On Fri, Jul 14, 2023 at 09:46:13PM +0000, Thinh Nguyen wrote: > On Fri, Jul 14, 2023, Ladislav Michl wrote: > > From: Ladislav Michl <ladis@linux-mips.org> > > > > As driver is rewritten and David no longer works for Marvell (Cavium), > > I'm to blame for breakage. > > > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > > --- > > CHANGES: > > - v2: None > > - v3: None > > > > drivers/usb/dwc3/dwc3-octeon.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c > > index dd47498f4efb..a68d568b11a9 100644 > > --- a/drivers/usb/dwc3/dwc3-octeon.c > > +++ b/drivers/usb/dwc3/dwc3-octeon.c > > @@ -1,11 +1,9 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > - * XHCI HCD glue for Cavium Octeon III SOCs. > > + * DWC3 glue for Cavium Octeon III SOCs. > > * > > * Copyright (C) 2010-2017 Cavium Networks > > - * > > - * This file is subject to the terms and conditions of the GNU General Public > > - * License. See the file "COPYING" in the main directory of this archive > > - * for more details. > > + * Copyright (C) 2023 Ladislav Michl <ladis@linux-mips.org> > > I may not be an expert with Copyright, but is it correct to put your > name rather than the entity this belongs to? That is up to the employer of the developer as to what they want to see here. Ladislav, you have run this by your legal group, right? thanks, greg k-h
On Sat, Jul 15, 2023 at 07:23:29AM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 14, 2023 at 09:46:13PM +0000, Thinh Nguyen wrote: > > On Fri, Jul 14, 2023, Ladislav Michl wrote: > > > From: Ladislav Michl <ladis@linux-mips.org> > > > > > > As driver is rewritten and David no longer works for Marvell (Cavium), > > > I'm to blame for breakage. > > > > > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > > > --- > > > CHANGES: > > > - v2: None > > > - v3: None > > > > > > drivers/usb/dwc3/dwc3-octeon.c | 10 ++++------ > > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c > > > index dd47498f4efb..a68d568b11a9 100644 > > > --- a/drivers/usb/dwc3/dwc3-octeon.c > > > +++ b/drivers/usb/dwc3/dwc3-octeon.c > > > @@ -1,11 +1,9 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > /* > > > - * XHCI HCD glue for Cavium Octeon III SOCs. > > > + * DWC3 glue for Cavium Octeon III SOCs. > > > * > > > * Copyright (C) 2010-2017 Cavium Networks > > > - * > > > - * This file is subject to the terms and conditions of the GNU General Public > > > - * License. See the file "COPYING" in the main directory of this archive > > > - * for more details. > > > + * Copyright (C) 2023 Ladislav Michl <ladis@linux-mips.org> > > > > I may not be an expert with Copyright, but is it correct to put your > > name rather than the entity this belongs to? > > That is up to the employer of the developer as to what they want to see > here. Ladislav, you have run this by your legal group, right? Not this particular one as I do not have any legal group :) I started this cleanup on my own, but it turned out there will be much more work needed to make USB on Octeon reliable. So after asking my contact person at Racom, copyright will be assigned to them. Note that it is not official statement yet, but as Thinh is on holidays anyway, we have quite some time to sort this out. I'll either confirm or send v5 - v4 is is on the way with Thinh's comments addressed, so I'm lookign forward for feedback. Thanks, ladis
diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c index dd47498f4efb..a68d568b11a9 100644 --- a/drivers/usb/dwc3/dwc3-octeon.c +++ b/drivers/usb/dwc3/dwc3-octeon.c @@ -1,11 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 /* - * XHCI HCD glue for Cavium Octeon III SOCs. + * DWC3 glue for Cavium Octeon III SOCs. * * Copyright (C) 2010-2017 Cavium Networks - * - * This file is subject to the terms and conditions of the GNU General Public - * License. See the file "COPYING" in the main directory of this archive - * for more details. + * Copyright (C) 2023 Ladislav Michl <ladis@linux-mips.org> */ #include <linux/bitfield.h> @@ -536,6 +534,6 @@ static struct platform_driver dwc3_octeon_driver = { module_platform_driver(dwc3_octeon_driver); MODULE_ALIAS("platform:dwc3-octeon"); -MODULE_AUTHOR("David Daney <david.daney@cavium.com>"); +MODULE_AUTHOR("Ladislav Michl <ladis@linux-mips.org>"); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("DesignWare USB3 OCTEON III Glue Layer");