| Message ID | 20230619154252.3951913-2-bigunclemax@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add support for Allwinner GPADC on D1/T113s/R329/T507 SoCs | expand |
Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a): > This patch adds SoCs names to Allwinner GPADC description to > make it more informative. Please reword to remove "This patch". > > Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC") I'm fine with the patch in general, but does this really warrant fixes tag? Best regards, Jernej > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index eb2b09ef5d5b..d93868684c7b 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -1105,7 +1105,7 @@ config STMPE_ADC > built-in ADC block (stmpe811). > > config SUN4I_GPADC > - tristate "Support for the Allwinner SoCs GPADC" > + tristate "Allwinner A10/A13/A31 and similar GPADCs driver" > depends on IIO > depends on MFD_SUN4I_GPADC || MACH_SUN8I > depends on THERMAL || !THERMAL_OF
On 11/07/2023 20:14, Jernej Škrabec wrote: > Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a): >> This patch adds SoCs names to Allwinner GPADC description to >> make it more informative. > > Please reword to remove "This patch". > >> >> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC") > > I'm fine with the patch in general, but does this really warrant fixes tag? > No, it's some fake fix. There is no bug here. Best regards, Krzysztof
On Wed, 12 Jul 2023 07:37:38 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 11/07/2023 20:14, Jernej Škrabec wrote: > > Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a): > >> This patch adds SoCs names to Allwinner GPADC description to > >> make it more informative. > > > > Please reword to remove "This patch". > > > >> > >> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC") > > > > I'm fine with the patch in general, but does this really warrant fixes tag? > > > > No, it's some fake fix. There is no bug here. > > Best regards, > Krzysztof > Dropped the tag. Thanks for pointing this out. Jonathan
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index eb2b09ef5d5b..d93868684c7b 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -1105,7 +1105,7 @@ config STMPE_ADC built-in ADC block (stmpe811). config SUN4I_GPADC - tristate "Support for the Allwinner SoCs GPADC" + tristate "Allwinner A10/A13/A31 and similar GPADCs driver" depends on IIO depends on MFD_SUN4I_GPADC || MACH_SUN8I depends on THERMAL || !THERMAL_OF
This patch adds SoCs names to Allwinner GPADC description to make it more informative. Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC") Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> --- drivers/iio/adc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)