diff mbox series

Bluetooth: Add VID/PID 0489/e102 for MediaTek MT7922

Message ID ZLSwfv2pQ5uH6bja@bud-laptop (mailing list archive)
State Superseded
Headers show
Series Bluetooth: Add VID/PID 0489/e102 for MediaTek MT7922 | expand

Checks

Context Check Description
tedd_an/pre-ci_am fail error: patch failed: drivers/bluetooth/btusb.c:628 error: drivers/bluetooth/btusb.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch

Commit Message

Wes Miser July 17, 2023, 3:07 a.m. UTC 
Tested on Acer Swift Edge 16 Notebook

Signed-off-by: Wes Miser <buddwm@gmail.com>
---
 drivers/bluetooth/btusb.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

bluez.test.bot@gmail.com July 17, 2023, 3:29 a.m. UTC | #1 
This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: drivers/bluetooth/btusb.c:628
error: drivers/bluetooth/btusb.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz July 17, 2023, 7:56 p.m. UTC | #2 
Hi Wes,

On Sun, Jul 16, 2023 at 8:07 PM Wes Miser <buddwm@gmail.com> wrote:
>
> Tested on Acer Swift Edge 16 Notebook
>
> Signed-off-by: Wes Miser <buddwm@gmail.com>
> ---
>  drivers/bluetooth/btusb.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 5ec4ad0a5c86..95f43d48f383 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -628,6 +628,9 @@ static const struct usb_device_id blacklist_table[] = {
>         { USB_DEVICE(0x0489, 0xe0f2), .driver_info = BTUSB_MEDIATEK |
>                                                      BTUSB_WIDEBAND_SPEECH |
>                                                      BTUSB_VALID_LE_STATES },
> +       { USB_DEVICE(0x0489, 0xe102), .driver_info = BTUSB_MEDIATEK |
> +                                                    BTUSB_WIDEBAND_SPEECH |
> +                                                    BTUSB_VALID_LE_STATES },
>
>         /* Additional Realtek 8723AE Bluetooth devices */
>         { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
> --
> 2.41.0

Please include the information from /sys/kernel/debug/usb/devices
Wes Miser July 17, 2023, 9:41 p.m. UTC | #3 
(Re-sending in text-only mode)

Hey Luiz,

I noticed that this may have already been submitted per
https://github.com/bluez/bluetooth-next/commit/159c43e9925e8f4655b8f834cbb864f5ecaf1778
(I was building against torvalds/linux and didn't notice this in
bluetooth-next).  In any case here's the information about the device
from my system:

T:  Bus=01 Lev=01 Prnt=01 Port=04 Cnt=02 Dev#=  3 Spd=480  MxCh= 0
D:  Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0489 ProdID=e102 Rev= 1.00
S:  Manufacturer=MediaTek Inc.
S:  Product=Wireless_Device
S:  SerialNumber=000000000
C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
A:  FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=125us
E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms
I:  If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  63 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  63 Ivl=1ms
I:* If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
E:  Ad=8a(I) Atr=03(Int.) MxPS=  64 Ivl=125us
E:  Ad=0a(O) Atr=03(Int.) MxPS=  64 Ivl=125us
I:  If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
E:  Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
E:  Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125u


On Mon, Jul 17, 2023 at 2:56 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Wes,
>
> On Sun, Jul 16, 2023 at 8:07 PM Wes Miser <buddwm@gmail.com> wrote:
> >
> > Tested on Acer Swift Edge 16 Notebook
> >
> > Signed-off-by: Wes Miser <buddwm@gmail.com>
> > ---
> >  drivers/bluetooth/btusb.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 5ec4ad0a5c86..95f43d48f383 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -628,6 +628,9 @@ static const struct usb_device_id blacklist_table[] = {
> >         { USB_DEVICE(0x0489, 0xe0f2), .driver_info = BTUSB_MEDIATEK |
> >                                                      BTUSB_WIDEBAND_SPEECH |
> >                                                      BTUSB_VALID_LE_STATES },
> > +       { USB_DEVICE(0x0489, 0xe102), .driver_info = BTUSB_MEDIATEK |
> > +                                                    BTUSB_WIDEBAND_SPEECH |
> > +                                                    BTUSB_VALID_LE_STATES },
> >
> >         /* Additional Realtek 8723AE Bluetooth devices */
> >         { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
> > --
> > 2.41.0
>
> Please include the information from /sys/kernel/debug/usb/devices
>
> --
> Luiz Augusto von Dentz
Luiz Augusto von Dentz July 17, 2023, 11:09 p.m. UTC | #4 
Hi Wes,

On Mon, Jul 17, 2023 at 2:41 PM Wes Miser <buddwm@gmail.com> wrote:
>
> (Re-sending in text-only mode)
>
> Hey Luiz,
>
> I noticed that this may have already been submitted per
> https://github.com/bluez/bluetooth-next/commit/159c43e9925e8f4655b8f834cbb864f5ecaf1778
> (I was building against torvalds/linux and didn't notice this in
> bluetooth-next).  In any case here's the information about the device
> from my system:
>
> T:  Bus=01 Lev=01 Prnt=01 Port=04 Cnt=02 Dev#=  3 Spd=480  MxCh= 0
> D:  Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0489 ProdID=e102 Rev= 1.00
> S:  Manufacturer=MediaTek Inc.
> S:  Product=Wireless_Device
> S:  SerialNumber=000000000
> C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> A:  FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=125us
> E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
> I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
> I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
> I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
> I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms
> I:  If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  63 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  63 Ivl=1ms
> I:* If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
> E:  Ad=8a(I) Atr=03(Int.) MxPS=  64 Ivl=125us
> E:  Ad=0a(O) Atr=03(Int.) MxPS=  64 Ivl=125us
> I:  If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
> E:  Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> E:  Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125u

Please rebase since apparently our CI couldn't apply it, and please
include the information above as part of the git commit description in
the v2.

>
> On Mon, Jul 17, 2023 at 2:56 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> >
> > Hi Wes,
> >
> > On Sun, Jul 16, 2023 at 8:07 PM Wes Miser <buddwm@gmail.com> wrote:
> > >
> > > Tested on Acer Swift Edge 16 Notebook
> > >
> > > Signed-off-by: Wes Miser <buddwm@gmail.com>
> > > ---
> > >  drivers/bluetooth/btusb.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > > index 5ec4ad0a5c86..95f43d48f383 100644
> > > --- a/drivers/bluetooth/btusb.c
> > > +++ b/drivers/bluetooth/btusb.c
> > > @@ -628,6 +628,9 @@ static const struct usb_device_id blacklist_table[] = {
> > >         { USB_DEVICE(0x0489, 0xe0f2), .driver_info = BTUSB_MEDIATEK |
> > >                                                      BTUSB_WIDEBAND_SPEECH |
> > >                                                      BTUSB_VALID_LE_STATES },
> > > +       { USB_DEVICE(0x0489, 0xe102), .driver_info = BTUSB_MEDIATEK |
> > > +                                                    BTUSB_WIDEBAND_SPEECH |
> > > +                                                    BTUSB_VALID_LE_STATES },
> > >
> > >         /* Additional Realtek 8723AE Bluetooth devices */
> > >         { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
> > > --
> > > 2.41.0
> >
> > Please include the information from /sys/kernel/debug/usb/devices
> >
> > --
> > Luiz Augusto von Dentz
Luiz Augusto von Dentz July 17, 2023, 11:34 p.m. UTC | #5 
Hi,

On Mon, Jul 17, 2023 at 4:09 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Wes,
>
> On Mon, Jul 17, 2023 at 2:41 PM Wes Miser <buddwm@gmail.com> wrote:
> >
> > (Re-sending in text-only mode)
> >
> > Hey Luiz,
> >
> > I noticed that this may have already been submitted per
> > https://github.com/bluez/bluetooth-next/commit/159c43e9925e8f4655b8f834cbb864f5ecaf1778

Right, that probably explains why CI couldn't apply it because it is
already fixed, so no need to resend.

> > (I was building against torvalds/linux and didn't notice this in
> > bluetooth-next).  In any case here's the information about the device
> > from my system:
> >
> > T:  Bus=01 Lev=01 Prnt=01 Port=04 Cnt=02 Dev#=  3 Spd=480  MxCh= 0
> > D:  Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
> > P:  Vendor=0489 ProdID=e102 Rev= 1.00
> > S:  Manufacturer=MediaTek Inc.
> > S:  Product=Wireless_Device
> > S:  SerialNumber=000000000
> > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> > A:  FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=125us
> > E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> > I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
> > I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
> > I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
> > I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
> > I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms
> > I:  If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=  63 Ivl=1ms
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=  63 Ivl=1ms
> > I:* If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
> > E:  Ad=8a(I) Atr=03(Int.) MxPS=  64 Ivl=125us
> > E:  Ad=0a(O) Atr=03(Int.) MxPS=  64 Ivl=125us
> > I:  If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none)
> > E:  Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> > E:  Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125u
>
> Please rebase since apparently our CI couldn't apply it, and please
> include the information above as part of the git commit description in
> the v2.
>
> >
> > On Mon, Jul 17, 2023 at 2:56 PM Luiz Augusto von Dentz
> > <luiz.dentz@gmail.com> wrote:
> > >
> > > Hi Wes,
> > >
> > > On Sun, Jul 16, 2023 at 8:07 PM Wes Miser <buddwm@gmail.com> wrote:
> > > >
> > > > Tested on Acer Swift Edge 16 Notebook
> > > >
> > > > Signed-off-by: Wes Miser <buddwm@gmail.com>
> > > > ---
> > > >  drivers/bluetooth/btusb.c | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > > > index 5ec4ad0a5c86..95f43d48f383 100644
> > > > --- a/drivers/bluetooth/btusb.c
> > > > +++ b/drivers/bluetooth/btusb.c
> > > > @@ -628,6 +628,9 @@ static const struct usb_device_id blacklist_table[] = {
> > > >         { USB_DEVICE(0x0489, 0xe0f2), .driver_info = BTUSB_MEDIATEK |
> > > >                                                      BTUSB_WIDEBAND_SPEECH |
> > > >                                                      BTUSB_VALID_LE_STATES },
> > > > +       { USB_DEVICE(0x0489, 0xe102), .driver_info = BTUSB_MEDIATEK |
> > > > +                                                    BTUSB_WIDEBAND_SPEECH |
> > > > +                                                    BTUSB_VALID_LE_STATES },
> > > >
> > > >         /* Additional Realtek 8723AE Bluetooth devices */
> > > >         { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
> > > > --
> > > > 2.41.0
> > >
> > > Please include the information from /sys/kernel/debug/usb/devices
> > >
> > > --
> > > Luiz Augusto von Dentz
>
>
>
> --
> Luiz Augusto von Dentz
diff mbox series

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5ec4ad0a5c86..95f43d48f383 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -628,6 +628,9 @@  static const struct usb_device_id blacklist_table[] = {
 	{ USB_DEVICE(0x0489, 0xe0f2), .driver_info = BTUSB_MEDIATEK |
 						     BTUSB_WIDEBAND_SPEECH |
 						     BTUSB_VALID_LE_STATES },
+	{ USB_DEVICE(0x0489, 0xe102), .driver_info = BTUSB_MEDIATEK |
+						     BTUSB_WIDEBAND_SPEECH |
+						     BTUSB_VALID_LE_STATES },
 
 	/* Additional Realtek 8723AE Bluetooth devices */
 	{ USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },