diff mbox series

[nfs-utils] start-statd: Fix shellcheck warnings

Message ID 20230709072028.829990-1-carnil@debian.org (mailing list archive)
State New, archived
Headers show
Series [nfs-utils] start-statd: Fix shellcheck warnings | expand

Commit Message

Salvatore Bonaccorso July 9, 2023, 7:20 a.m. UTC 
From: Ben Hutchings <benh@debian.org>

shellcheck currently complains:

In utils/statd/start-statd line 14:
       [ 1`cat /run/rpc.statd.pid` -gt 1 ] &&
          ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
          ^----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
       [ 1$(cat /run/rpc.statd.pid) -gt 1 ] &&

In utils/statd/start-statd line 15:
       kill -0 `cat /run/rpc.statd.pid` > /dev/null 2>&1
               ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
               ^----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
       kill -0 $(cat /run/rpc.statd.pid) > /dev/null 2>&1

Use quotes and $() as recommended.

Signed-off-by: Ben Hutchings <benh@debian.org>
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 utils/statd/start-statd | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Steve Dickson July 17, 2023, 9:49 p.m. UTC | #1 
On 7/9/23 3:20 AM, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <benh@debian.org>
> 
> shellcheck currently complains:
> 
> In utils/statd/start-statd line 14:
>         [ 1`cat /run/rpc.statd.pid` -gt 1 ] &&
>            ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
>            ^----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
> 
> Did you mean:
>         [ 1$(cat /run/rpc.statd.pid) -gt 1 ] &&
> 
> In utils/statd/start-statd line 15:
>         kill -0 `cat /run/rpc.statd.pid` > /dev/null 2>&1
>                 ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
>                 ^----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
> 
> Did you mean:
>         kill -0 $(cat /run/rpc.statd.pid) > /dev/null 2>&1
> 
> Use quotes and $() as recommended.
> 
> Signed-off-by: Ben Hutchings <benh@debian.org>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Committed (tag: nfs-utils-2-6-4-rc3)

steved.
> ---
>   utils/statd/start-statd | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/statd/start-statd b/utils/statd/start-statd
> index 2baf73c385cf..b11a7d91a7f6 100755
> --- a/utils/statd/start-statd
> +++ b/utils/statd/start-statd
> @@ -11,8 +11,8 @@ exec 9> /run/rpc.statd.lock
>   flock -e 9
>   
>   if [ -s /run/rpc.statd.pid ] &&
> -       [ 1`cat /run/rpc.statd.pid` -gt 1 ] &&
> -       kill -0 `cat /run/rpc.statd.pid` > /dev/null 2>&1
> +       [ "1$(cat /run/rpc.statd.pid)" -gt 1 ] &&
> +       kill -0 "$(cat /run/rpc.statd.pid)" > /dev/null 2>&1
>   then
>       # statd already running - must have been slow to respond.
>       exit 0
diff mbox series

Patch

diff --git a/utils/statd/start-statd b/utils/statd/start-statd
index 2baf73c385cf..b11a7d91a7f6 100755
--- a/utils/statd/start-statd
+++ b/utils/statd/start-statd
@@ -11,8 +11,8 @@  exec 9> /run/rpc.statd.lock
 flock -e 9
 
 if [ -s /run/rpc.statd.pid ] &&
-       [ 1`cat /run/rpc.statd.pid` -gt 1 ] &&
-       kill -0 `cat /run/rpc.statd.pid` > /dev/null 2>&1
+       [ "1$(cat /run/rpc.statd.pid)" -gt 1 ] &&
+       kill -0 "$(cat /run/rpc.statd.pid)" > /dev/null 2>&1
 then
     # statd already running - must have been slow to respond.
     exit 0