| Message ID | 20230718070114.3871-1-andre.werner@systec-electronic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001 | expand |
On 18/07/2023 09:01, Andre Werner wrote: > This is the initial description. > > Signed-off-by: Andre Werner <andre.werner@systec-electronic.com> > > v1: Using separate dt-binding hs300x.yaml > v2: Reviewer recommends documentation of driver dt-binding in > trivial-devices.yaml because the driver has no special properties > to describe. Changelog goes after ---. Even if you intended to keep it in commit msg, definitely not after SoB. Does this even pass checkpatch? > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index ba2bfb547909..a4f4701337cf 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -315,6 +315,8 @@ properties: > - plx,pex8648 > # Pulsedlight LIDAR range-finding sensor > - pulsedlight,lidar-lite-v2 > + # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors > + - renesas,hs3001 What about the rest of the devices - hs300[234]? Usually we ask for specific compatibles, that's why separate binding made some sense. Best regards, Krzysztof
On 18/07/2023 09:01, Andre Werner wrote: > This is the initial description. > > Signed-off-by: Andre Werner <andre.werner@systec-electronic.com> > > v1: Using separate dt-binding hs300x.yaml > v2: Reviewer recommends documentation of driver dt-binding in > trivial-devices.yaml because the driver has no special properties > to describe. BTW, you already sent v2, so this is v3. Please version your patches correctly. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index ba2bfb547909..a4f4701337cf 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -315,6 +315,8 @@ properties: - plx,pex8648 # Pulsedlight LIDAR range-finding sensor - pulsedlight,lidar-lite-v2 + # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors + - renesas,hs3001 # Renesas ISL29501 time-of-flight sensor - renesas,isl29501 # Rohm DH2228FV
This is the initial description. Signed-off-by: Andre Werner <andre.werner@systec-electronic.com> v1: Using separate dt-binding hs300x.yaml v2: Reviewer recommends documentation of driver dt-binding in trivial-devices.yaml because the driver has no special properties to describe. --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)