| Message ID | 20230718105213.1275-3-henning.schild@siemens.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | platform/x86: move simatic ipc drivers into subdir | expand |
On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote: > If a user did choose to enable Siemens Simatic platform support they > likely want the LED drivers to be enabled without having to flip more > config switches. So we make the LED drivers config switch default to > the platform driver switches value. Same as per previous patch.
Am Tue, 18 Jul 2023 17:21:04 +0300 schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote: > > If a user did choose to enable Siemens Simatic platform support they > > likely want the LED drivers to be enabled without having to flip > > more config switches. So we make the LED drivers config switch > > default to the platform driver switches value. > > Same as per previous patch. > Same as per previous patch.
On Tue, 18 Jul 2023, Henning Schild wrote: > Am Tue, 18 Jul 2023 17:21:04 +0300 > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > > > On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote: > > > If a user did choose to enable Siemens Simatic platform support they > > > likely want the LED drivers to be enabled without having to flip > > > more config switches. So we make the LED drivers config switch > > > default to the platform driver switches value. > > > > Same as per previous patch. > > > > Same as per previous patch. Same as per previous patch.
Am Wed, 19 Jul 2023 09:43:01 +0100 schrieb Lee Jones <lee@kernel.org>: > On Tue, 18 Jul 2023, Henning Schild wrote: > > > Am Tue, 18 Jul 2023 17:21:04 +0300 > > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > > > > > On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote: > > > > If a user did choose to enable Siemens Simatic platform support > > > > they likely want the LED drivers to be enabled without having > > > > to flip more config switches. So we make the LED drivers config > > > > switch default to the platform driver switches value. > > > > > > Same as per previous patch. > > > > > > > Same as per previous patch. > > Same as per previous patch. > I will assume that you are asking me to "default y", as discussed on that other patch. And will send a v2 accordingly. In case the ordering of default, depends etc matters to you, please say so. Henning
diff --git a/drivers/leds/simple/Kconfig b/drivers/leds/simple/Kconfig index 44fa0f93cb3b..9666bf22d554 100644 --- a/drivers/leds/simple/Kconfig +++ b/drivers/leds/simple/Kconfig @@ -2,6 +2,7 @@ config LEDS_SIEMENS_SIMATIC_IPC tristate "LED driver for Siemens Simatic IPCs" depends on SIEMENS_SIMATIC_IPC + default SIEMENS_SIMATIC_IPC help This option enables support for the LEDs of several Industrial PCs from Siemens.
If a user did choose to enable Siemens Simatic platform support they likely want the LED drivers to be enabled without having to flip more config switches. So we make the LED drivers config switch default to the platform driver switches value. Signed-off-by: Henning Schild <henning.schild@siemens.com> --- drivers/leds/simple/Kconfig | 1 + 1 file changed, 1 insertion(+)