mbox series

[0/3] configure.ac: misc configure fixes

Message ID 20230719145211.17854-2-aherrmann@suse.de (mailing list archive)
Headers show
Series configure.ac: misc configure fixes | expand

Message

Andreas Herrmann July 19, 2023, 2:29 p.m. UTC 
Some of the configure options are not working as expected.
I first encountered this when using '--with-expat=no'.
Following patches address this.

I've also checked configure options for 'libpcre', 'openssl' (together
with 'make OPENSSL_SHA1=yes ...'), and 'tcltk'. These are working
correctly.

As a test I've run 'make test' when disabling support of a package.
I always had to use 'export GIT_SKIP_TESTS="t5801.1[4-7] t5801.31"' to
skip some failing tests. Those failed also with default build.

When disabling iconv ('configure --without-iconv') further tests are
failing. In this case I've used
'export GIT_SKIP_TESTS="t5801.1[4-7] t5801.31 \
t0028* t2082.2 t3434* t390[01]* \
t4041* t4059* t4060.8 t4201.12 t4205* t4210* t4254.[34] \
t5100* t6006* t7102.2 t8005* t9300.193 t9350*"'
to ensure that 'make test' completed without exiting early.

Andreas Herrmann (3):
  configure.ac: don't overwrite NO_EXPAT option
  configure.ac: don't overwrite NO_CURL option
  configure.ac: always save NO_ICONV to config.status

 configure.ac | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Junio C Hamano July 19, 2023, 9:35 p.m. UTC | #1 
Andreas Herrmann <aherrmann@suse.de> writes:

> Andreas Herrmann (3):
>   configure.ac: don't overwrite NO_EXPAT option
>   configure.ac: don't overwrite NO_CURL option
>   configure.ac: always save NO_ICONV to config.status

All patches look good.

Thanks, will queue.