| Message ID | 20230719174015.68153-3-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RK3588 USB3 host controller support | expand |
Hi Sebastian, On 7/19/23 19:40, Sebastian Reichel wrote: > RK3588 has three USB3 controllers. One of them is host-only and uses > the naneng-combphy. The other two are dual-role and using a different > PHY that is not yet supported upstream. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 29 +++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > index b9b509257aaa..416581dd3bb5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > @@ -443,6 +443,35 @@ usb_host1_ohci: usb@fc8c0000 { > status = "disabled"; > }; > > + usbhost3_0: usb@fcd00000 { I'd recommend aligning the handle names with rk356x.dtsi: usb_host{0,1,..}_{e,o,x}hci I saw that your USB2 series follows this convention already, so let's stick to it here as well. > + compatible = "rockchip,rk3588-dwc3-host", "rockchip,rk3399-dwc3"; > + clocks = <&cru REF_CLK_USB3OTG2>, <&cru SUSPEND_CLK_USB3OTG2>, > + <&cru ACLK_USB3OTG2>, <&cru CLK_UTMI_OTG2>, > + <&cru PCLK_PHP_ROOT>, <&cru CLK_PIPEPHY2_PIPE_U3_G>; > + clock-names = "ref", "suspend", "bus", "utmi", "php", "pipe"; > + ranges; > + resets = <&cru SRST_A_USB3OTG2>; > + reset-names = "usb3-host"; > + #address-cells = <2>; > + #size-cells = <2>; > + status = "disabled"; > + > + usbhost_dwc3_0: usb@fcd00000 { I had the impression that the embedded nodes were out of fashion and the preferred way was to have one node with the compatible = "rockchip,rk3568-dwc3", "snps,dwc3"; Again, try to align it with rk356x.dtsi. Thanks and best regards, Michael > + compatible = "snps,dwc3"; > + reg = <0x0 0xfcd00000 0x0 0x400000>; > + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH 0>; > + dr_mode = "host"; > + phys = <&combphy2_psu PHY_TYPE_USB3>; > + phy-names = "usb3-phy"; > + phy_type = "utmi_wide"; > + snps,dis_enblslpm_quirk; > + snps,dis-u2-freeclk-exists-quirk; > + snps,dis-del-phy-power-chg-quirk; > + snps,dis-tx-ipgap-linecheck-quirk; > + snps,dis_rxdet_inp3_quirk; > + }; > + }; > + > sys_grf: syscon@fd58c000 { > compatible = "rockchip,rk3588-sys-grf", "syscon"; > reg = <0x0 0xfd58c000 0x0 0x1000>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index b9b509257aaa..416581dd3bb5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi @@ -443,6 +443,35 @@ usb_host1_ohci: usb@fc8c0000 { status = "disabled"; }; + usbhost3_0: usb@fcd00000 { + compatible = "rockchip,rk3588-dwc3-host", "rockchip,rk3399-dwc3"; + clocks = <&cru REF_CLK_USB3OTG2>, <&cru SUSPEND_CLK_USB3OTG2>, + <&cru ACLK_USB3OTG2>, <&cru CLK_UTMI_OTG2>, + <&cru PCLK_PHP_ROOT>, <&cru CLK_PIPEPHY2_PIPE_U3_G>; + clock-names = "ref", "suspend", "bus", "utmi", "php", "pipe"; + ranges; + resets = <&cru SRST_A_USB3OTG2>; + reset-names = "usb3-host"; + #address-cells = <2>; + #size-cells = <2>; + status = "disabled"; + + usbhost_dwc3_0: usb@fcd00000 { + compatible = "snps,dwc3"; + reg = <0x0 0xfcd00000 0x0 0x400000>; + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH 0>; + dr_mode = "host"; + phys = <&combphy2_psu PHY_TYPE_USB3>; + phy-names = "usb3-phy"; + phy_type = "utmi_wide"; + snps,dis_enblslpm_quirk; + snps,dis-u2-freeclk-exists-quirk; + snps,dis-del-phy-power-chg-quirk; + snps,dis-tx-ipgap-linecheck-quirk; + snps,dis_rxdet_inp3_quirk; + }; + }; + sys_grf: syscon@fd58c000 { compatible = "rockchip,rk3588-sys-grf", "syscon"; reg = <0x0 0xfd58c000 0x0 0x1000>;
RK3588 has three USB3 controllers. One of them is host-only and uses the naneng-combphy. The other two are dual-role and using a different PHY that is not yet supported upstream. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 29 +++++++++++++++++++++++ 1 file changed, 29 insertions(+)