diff mbox series

gpio: msc313: remove unnecessary call to platform_set_drvdata()

Message ID 20230721131157.26640-1-aboutphysycs@gmail.com (mailing list archive)
State New, archived
Headers show
Series gpio: msc313: remove unnecessary call to platform_set_drvdata() | expand

Commit Message

Andrei Coardos July 21, 2023, 1:11 p.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-msc313.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andy Shevchenko July 21, 2023, 4:14 p.m. UTC | #1 
On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Romain Perier July 27, 2023, 7 a.m. UTC | #2 
Hi,

The private data is "struct msc313_gpio *gpio". This private data is
"binded" to the gpio_chip via devm_gpiochip_add_data, right ?
Then it is retrieved via gpiochip_get_data(chip), right ?

Romain

Le mar. 25 juil. 2023 à 15:22, Andy Shevchenko <andy@kernel.org> a écrit :
>
> On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > > This function call was found to be unnecessary as there is no equivalent
> > > platform_get_drvdata() call to access the private data of the driver.
>
> Not true.
>
> > > Also, the private data is defined in this driver, so there is no risk of
> > > it being accessed outside of this driver file.
> >
> > Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
> I have to withdraw this, the patch is wrong.
> NAK.
>
> Sorry for the confusion (I have looked for the wrong pattern).
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Andy Shevchenko July 27, 2023, 10:09 a.m. UTC | #3 
On Thu, Jul 27, 2023 at 09:00:36AM +0200, Romain Perier wrote:

First of all, please do not top-post!

> The private data is "struct msc313_gpio *gpio". This private data is
> "binded" to the gpio_chip via devm_gpiochip_add_data, right ?

No.

> Then it is retrieved via gpiochip_get_data(chip), right ?

No.

The driver data is used in PM callbacks. See below.

> Le mar. 25 juil. 2023 à 15:22, Andy Shevchenko <andy@kernel.org> a écrit :
> >
> > On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> > > On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > > > This function call was found to be unnecessary as there is no equivalent
> > > > platform_get_drvdata() call to access the private data of the driver.
> >
> > Not true.

^^^^

> > > > Also, the private data is defined in this driver, so there is no risk of
> > > > it being accessed outside of this driver file.
> > >
> > > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> >
> > I have to withdraw this, the patch is wrong.
> > NAK.
> >
> > Sorry for the confusion (I have looked for the wrong pattern).
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c
index 036ad2324892..8e6835399d24 100644
--- a/drivers/gpio/gpio-msc313.c
+++ b/drivers/gpio/gpio-msc313.c
@@ -643,8 +643,6 @@  static int msc313_gpio_probe(struct platform_device *pdev)
 	if (IS_ERR(gpio->base))
 		return PTR_ERR(gpio->base);
 
-	platform_set_drvdata(pdev, gpio);
-
 	gpiochip = devm_kzalloc(dev, sizeof(*gpiochip), GFP_KERNEL);
 	if (!gpiochip)
 		return -ENOMEM;