| Message ID | e6e6c227-6789-9c82-3561-530095f46e02@kontron.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] hwmon: nct7802: Fix for temp6 (PECI1) processed even if PECI1 disabled | expand |
On Fri, Jul 21, 2023 at 07:29:19PM +0200, Gilles BULOZ wrote: > Because of hex value 0x46 used instead of decimal 46, the temp6 > (PECI1) temperature is always declared visible and then displayed > even if disabled in the chip > > Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com> Applied. In the future, please version your patches and provide change logs. Also, please fix your e-mail address configuration to avoid the following checkpatch warning. From:/Signed-off-by: email name mismatch: 'From: Gilles BULOZ <gilles.buloz@kontron.com>' != 'Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com>' Thanks, Guenter > --- > drivers/hwmon/nct7802.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c > index 9339bfc..024cff1 100644 > --- a/drivers/hwmon/nct7802.c > +++ b/drivers/hwmon/nct7802.c > @@ -725,7 +725,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, > if (index >= 38 && index < 46 && !(reg & 0x01)) /* PECI 0 */ > return 0; > > - if (index >= 0x46 && (!(reg & 0x02))) /* PECI 1 */ > + if (index >= 46 && !(reg & 0x02)) /* PECI 1 */ > return 0; > > return attr->mode;
On Fri, Jul 21, 2023 at 11:27:16AM -0700, Guenter Roeck wrote: > On Fri, Jul 21, 2023 at 07:29:19PM +0200, Gilles BULOZ wrote: > > Because of hex value 0x46 used instead of decimal 46, the temp6 > > (PECI1) temperature is always declared visible and then displayed > > even if disabled in the chip > > > > Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com> > > Applied. > Actually, no, the patch did not apply. $ git am -s -3 index.html Applying: hwmon: nct7802: Fix for temp6 (PECI1) processed even if PECI1 disabled Using index info to reconstruct a base tree... error: patch failed: drivers/hwmon/nct7802.c:725 error: drivers/hwmon/nct7802.c: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. Patch failed at 0001 hwmon: nct7802: Fix for temp6 (PECI1) processed even if PECI1 disabled hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please resend and make sure it applies. Thanks, Guenter > In the future, please version your patches and provide change logs. > Also, please fix your e-mail address configuration to avoid the > following checkpatch warning. > > From:/Signed-off-by: email name mismatch: 'From: Gilles BULOZ <gilles.buloz@kontron.com>' != 'Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com>' > > Thanks, > Guenter > > > --- > > drivers/hwmon/nct7802.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c > > index 9339bfc..024cff1 100644 > > --- a/drivers/hwmon/nct7802.c > > +++ b/drivers/hwmon/nct7802.c > > @@ -725,7 +725,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, > > if (index >= 38 && index < 46 && !(reg & 0x01)) /* PECI 0 */ > > return 0; > > > > - if (index >= 0x46 && (!(reg & 0x02))) /* PECI 1 */ > > + if (index >= 46 && !(reg & 0x02)) /* PECI 1 */ > > return 0; > > > > return attr->mode;
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index 9339bfc..024cff1 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c @@ -725,7 +725,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, if (index >= 38 && index < 46 && !(reg & 0x01)) /* PECI 0 */ return 0; - if (index >= 0x46 && (!(reg & 0x02))) /* PECI 1 */ + if (index >= 46 && !(reg & 0x02)) /* PECI 1 */ return 0; return attr->mode;
Because of hex value 0x46 used instead of decimal 46, the temp6 (PECI1) temperature is always declared visible and then displayed even if disabled in the chip Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com> --- drivers/hwmon/nct7802.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)