mbox series

[0/2] btrfs: fixes for missing error reporting when attaching to a transaction

Message ID cover.1689932501.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: fixes for missing error reporting when attaching to a transaction | expand

Message

Filipe Manana July 21, 2023, 9:49 a.m. UTC
From: Filipe Manana <fdmanana@suse.com>

These fix missing error checks and returns when attaching to a transaction
in barrier mode, and waiting for a transaction to commit and finish. These
can make things like an fsync that fallbacks to a transaction commit to
report success to user space when a transaction was aborted and the inode
changes were therefore not persisted. More details on the change logs.

Filipe Manana (2):
  btrfs: check if the transaction was aborted at btrfs_wait_for_commit()
  btrfs: check for commit error at btrfs_attach_transaction_barrier()

 fs/btrfs/transaction.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

David Sterba July 21, 2023, 11:17 p.m. UTC | #1
On Fri, Jul 21, 2023 at 10:49:19AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> These fix missing error checks and returns when attaching to a transaction
> in barrier mode, and waiting for a transaction to commit and finish. These
> can make things like an fsync that fallbacks to a transaction commit to
> report success to user space when a transaction was aborted and the inode
> changes were therefore not persisted. More details on the change logs.
> 
> Filipe Manana (2):
>   btrfs: check if the transaction was aborted at btrfs_wait_for_commit()
>   btrfs: check for commit error at btrfs_attach_transaction_barrier()

Added to misc-next, thanks.