| Message ID | ZLbATQRjOl09aLAp@zephyrusG14 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards | expand |
On Tue, Jul 18, 2023 at 10:09:41PM +0530, Yogesh Hegde wrote: > This patch fixes an issue affecting the Wifi/Bluetooth connectivity on > ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth > on ROCK Pi 4 boards") introduced a problem with the clock configuration. > Specifically, the clock-names property of the sdio-pwrseq node was not > updated to 'lpo', causing the driver to wait indefinitely for the wrong clock > signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper > initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards. > > To address this, this patch updates the clock-names property of the > sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node. > > This patch has been tested on ROCK Pi 4B. > > Fixes: f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") > Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com> Why are you saying this fixes a specific old commit and not also properly cc: the stable@vger.kernel.org alias? Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
On Tue, Jul 18, 2023 at 07:37:21PM +0200, Greg KH wrote: > On Tue, Jul 18, 2023 at 10:09:41PM +0530, Yogesh Hegde wrote: > > This patch fixes an issue affecting the Wifi/Bluetooth connectivity on > > ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth > > on ROCK Pi 4 boards") introduced a problem with the clock configuration. > > Specifically, the clock-names property of the sdio-pwrseq node was not > > updated to 'lpo', causing the driver to wait indefinitely for the wrong clock > > signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper > > initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards. > > > > To address this, this patch updates the clock-names property of the > > sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node. > > > > This patch has been tested on ROCK Pi 4B. > > > > Fixes: f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") > > Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com> > > Why are you saying this fixes a specific old commit and not also > properly cc: the stable@vger.kernel.org alias? It is a mistake on my part. I apologize for the mistake. > > Please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. Thanks for the link, I will read through it and resend a v3 of the patch with fixes. Thanks and Regards -- Yogesh
On Tue, 18 Jul 2023 22:09:41 +0530, Yogesh Hegde wrote: > This patch fixes an issue affecting the Wifi/Bluetooth connectivity on > ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth > on ROCK Pi 4 boards") introduced a problem with the clock configuration. > Specifically, the clock-names property of the sdio-pwrseq node was not > updated to 'lpo', causing the driver to wait indefinitely for the wrong clock > signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper > initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards commit: ebceec271e552a2b05e47d8ef0597052b1a39449 and added the "Cc: stable@vger.kernel.org" Best regards,
Hi Heiko, On Mon, Jul 24, 2023 at 08:52:37PM +0200, Heiko Stuebner wrote: > > Applied, thanks! > > [1/1] arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards > commit: ebceec271e552a2b05e47d8ef0597052b1a39449 > > and added the "Cc: stable@vger.kernel.org" > > Best regards, > -- > Heiko Stuebner <heiko@sntech.de> Thanks and my heartfelt gratitude to you for fixing and applying the patch. I am truly grateful for your support. Due to an increased workload and pressing commitments, there is a considerable delay in my responses and patch submissions. Thanks and Regards -- Yogesh
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi index 907071d4fe80..795a70948d9a 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi @@ -45,7 +45,7 @@ led-0 { sdio_pwrseq: sdio-pwrseq { compatible = "mmc-pwrseq-simple"; clocks = <&rk808 1>; - clock-names = "ext_clock"; + clock-names = "lpo"; pinctrl-names = "default"; pinctrl-0 = <&wifi_enable_h>; reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
This patch fixes an issue affecting the Wifi/Bluetooth connectivity on ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") introduced a problem with the clock configuration. Specifically, the clock-names property of the sdio-pwrseq node was not updated to 'lpo', causing the driver to wait indefinitely for the wrong clock signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards. To address this, this patch updates the clock-names property of the sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node. This patch has been tested on ROCK Pi 4B. Fixes: f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com> --- Changes in v2: Added the Fixes tag as per feedback from Vincent Legoll <vincent.legoll@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)