| Message ID | f9128b6d2307a4a53904930cae864dcc@208suo.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | napi: remove spaces after '(' | expand |
On Wed, 19 Jul 2023 14:50:11 +0800 sunran001@208suo.com wrote: > Fix four occurrences of the checkpatch error: > > ERROR: space prohibited after that open parenthesis '(' > > Signed-off-by: Ran Sun <sunran001@208suo.com> > --- > include/trace/events/napi.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h > index 6678cf8b235b..98fb9e0d2219 100644 > --- a/include/trace/events/napi.h > +++ b/include/trace/events/napi.h > @@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll, > TP_ARGS(napi, work, budget), > > TP_STRUCT__entry( > - __field( struct napi_struct *, napi) > - __string( dev_name, napi->dev ? napi->dev->name : NO_DEV) > - __field( int, work) > - __field( int, budget) > + __field(struct napi_struct *, napi) > + __string(dev_name, napi->dev ? napi->dev->name : NO_DEV) > + __field(int, work) > + __field(int, budget) NACK! Which version looks better? checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM! -- Steve > ), > > TP_fast_assign(
diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h index 6678cf8b235b..98fb9e0d2219 100644 --- a/include/trace/events/napi.h +++ b/include/trace/events/napi.h @@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll, TP_ARGS(napi, work, budget), TP_STRUCT__entry( - __field( struct napi_struct *, napi) - __string( dev_name, napi->dev ? napi->dev->name : NO_DEV) - __field( int, work) - __field( int, budget) + __field(struct napi_struct *, napi) + __string(dev_name, napi->dev ? napi->dev->name : NO_DEV) + __field(int, work) + __field(int, budget) ), TP_fast_assign(
Fix four occurrences of the checkpatch error: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Ran Sun <sunran001@208suo.com> --- include/trace/events/napi.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)