mbox series

[v4,00/10] phy: qcom-qmp-combo: convert to newer style of bindings

Message ID 20230711120916.4165894-1-dmitry.baryshkov@linaro.org
Headers show
Series phy: qcom-qmp-combo: convert to newer style of bindings | expand

Message

Dmitry Baryshkov July 11, 2023, 12:09 p.m. UTC
Reviewing several patchsets for newer platforms made me understand that
having two styles of QMP PHY bindings causes confusion. Despite binding
documents having notes telling that old bindings should be used for
older platforms, it is too easy to attempt adding new platform with
older QMP PHY binding. Thus let's have just a single documented style of
bindings.

Changes since v3:
- Rebased on top of phy/next
- Squashed sm8150 changes from [1] (which were not picked up) with the
  sm8150 patch from this patchset.

Changes since v2:
 - Rebased on top of phy/next and updated [1]

Changes since v1:
 - Split large patchset into smaller parts
 - Reworked sm8150 too (following changes in [1])
 - Unified bindings with the existing ones
   - use shared list of clocks,
   - added sc7180 as a first grade entry
   - dropped useless descriptions
   - removed ref_clk_src clock
   - dropped second example

[1] https://lore.kernel.org/linux-phy/20230521195420.12454-1-dmitry.baryshkov@linaro.org/

Dmitry Baryshkov (10):
  dt-bindings: phy: migrate combo QMP PHY bindings to
    qcom,sc8280xp-qmp-usb43dp-phy.yaml
  phy: qcom-qmp-combo: simplify clock handling
  phy: qcom-qmp-combo: populate offsets for all combo PHYs
  phy: qcom-qmp-combo: add qcom,sc7280-qmp-usb3-dp-phy compat entry
  arm64: dts: qcom: sc7180: switch USB+DP QMP PHY to new style of
    bindings
  arm64: dts: qcom: sc7280: link usb3_phy_wrapper_gcc_usb30_pipe_clk
  arm64: dts: qcom: sc7280: switch USB+DP QMP PHY to new style of
    bindings
  arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of
    bindings
  arm64: dts: qcom: sm8150: switch USB+DP QMP PHY to new style of
    bindings
  arm64: dts: qcom: sm8250: switch USB+DP QMP PHY to new style of
    bindings

 .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml      | 284 ------------------
 .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    |  46 ++-
 arch/arm64/boot/dts/qcom/sc7180.dtsi          |  57 ++--
 arch/arm64/boot/dts/qcom/sc7280.dtsi          |  60 ++--
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |  57 ++--
 arch/arm64/boot/dts/qcom/sm8150.dtsi          |  44 ++-
 arch/arm64/boot/dts/qcom/sm8250.dtsi          |  49 +--
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c     |  79 +++--
 8 files changed, 168 insertions(+), 508 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml

Comments

Vinod Koul July 24, 2023, 10:56 a.m. UTC | #1
On Tue, 11 Jul 2023 15:09:06 +0300, Dmitry Baryshkov wrote:
> Reviewing several patchsets for newer platforms made me understand that
> having two styles of QMP PHY bindings causes confusion. Despite binding
> documents having notes telling that old bindings should be used for
> older platforms, it is too easy to attempt adding new platform with
> older QMP PHY binding. Thus let's have just a single documented style of
> bindings.
> 
> [...]

Applied, thanks!

[01/10] dt-bindings: phy: migrate combo QMP PHY bindings to qcom,sc8280xp-qmp-usb43dp-phy.yaml
        commit: 57a79ce964d76757c2fd21e097bcd9eb44884def
[02/10] phy: qcom-qmp-combo: simplify clock handling
        commit: 28e265bf84a8f885b3156f24dc246bf1d7bb40a5
[03/10] phy: qcom-qmp-combo: populate offsets for all combo PHYs
        commit: a542ae82dfdd1e84f84593161ffc586e72cc992d
[04/10] phy: qcom-qmp-combo: add qcom,sc7280-qmp-usb3-dp-phy compat entry
        commit: 486392f44dd96aeb34bbbc1b119bc5d332f1164f

Best regards,
Bjorn Andersson Sept. 14, 2023, 4:04 p.m. UTC | #2
On Tue, 11 Jul 2023 15:09:06 +0300, Dmitry Baryshkov wrote:
> Reviewing several patchsets for newer platforms made me understand that
> having two styles of QMP PHY bindings causes confusion. Despite binding
> documents having notes telling that old bindings should be used for
> older platforms, it is too easy to attempt adding new platform with
> older QMP PHY binding. Thus let's have just a single documented style of
> bindings.
> 
> [...]

Applied, thanks!

[05/10] arm64: dts: qcom: sc7180: switch USB+DP QMP PHY to new style of bindings
        commit: ebb840b00b7f9fc15153b37a7d9ec5b47a5308c1
[06/10] arm64: dts: qcom: sc7280: link usb3_phy_wrapper_gcc_usb30_pipe_clk
        commit: 70c4a1ca13b333b00e01266d299605fa1041b0d5
[07/10] arm64: dts: qcom: sc7280: switch USB+DP QMP PHY to new style of bindings
        commit: 36888ed83f998c3335272f9e353eaf6d109e2429
[08/10] arm64: dts: qcom: sdm845: switch USB+DP QMP PHY to new style of bindings
        commit: a9ecdec45a3a59057a68cf61ba4569d34caea5fc
[09/10] arm64: dts: qcom: sm8150: switch USB+DP QMP PHY to new style of bindings
        commit: 0459c56e538bd4d8ed7f128d7a50a8990cbcb7b8
[10/10] arm64: dts: qcom: sm8250: switch USB+DP QMP PHY to new style of bindings
        commit: 1a47520b314a0f201fcec8c741ae60608380e78c

Best regards,