| Message ID | 20230724122029.1430482-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: ufs: qcom: remove unused variable | expand |
On 23-07-24 14:19:58, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A recent change removed the only user of a local variable that needs > to now also be removed: > > drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler': > drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable] > > Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/ufs/host/ufs-qcom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 3ee5ff905f9a6..5728e94b6527b 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data) > struct msi_desc *desc = data; > struct device *dev = msi_desc_to_dev(desc); > struct ufs_hba *hba = dev_get_drvdata(dev); > - struct ufs_qcom_host *host = ufshcd_get_variant(hba); > u32 id = desc->msi_index; > struct ufs_hw_queue *hwq = &hba->uhq[id]; > > -- > 2.39.2 >
On Mon, Jul 24, 2023 at 02:19:58PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A recent change removed the only user of a local variable that needs > to now also be removed: > > drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler': > drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable] > > Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> - Mani > --- > drivers/ufs/host/ufs-qcom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 3ee5ff905f9a6..5728e94b6527b 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data) > struct msi_desc *desc = data; > struct device *dev = msi_desc_to_dev(desc); > struct ufs_hba *hba = dev_get_drvdata(dev); > - struct ufs_qcom_host *host = ufshcd_get_variant(hba); > u32 id = desc->msi_index; > struct ufs_hw_queue *hwq = &hba->uhq[id]; > > -- > 2.39.2 >
On Mon, Jul 24, 2023 at 02:19:58PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A recent change removed the only user of a local variable that needs > to now also be removed: > > drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler': > drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable] > > Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks for the patch! Reported-by: kernelci.org bot <bot@kernelci.org> Link: https://lore.kernel.org/llvm/64c00cd4.630a0220.6ad79.0eac@mx.google.com/ Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/ufs/host/ufs-qcom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 3ee5ff905f9a6..5728e94b6527b 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data) > struct msi_desc *desc = data; > struct device *dev = msi_desc_to_dev(desc); > struct ufs_hba *hba = dev_get_drvdata(dev); > - struct ufs_qcom_host *host = ufshcd_get_variant(hba); > u32 id = desc->msi_index; > struct ufs_hw_queue *hwq = &hba->uhq[id]; > > -- > 2.39.2 >
Arnd, > A recent change removed the only user of a local variable that needs > to now also be removed: > > drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler': > drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable] Applied to 6.6/scsi-staging, thanks!
On Mon, 24 Jul 2023 14:19:58 +0200, Arnd Bergmann wrote: > A recent change removed the only user of a local variable that needs > to now also be removed: > > drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler': > drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable] > > > [...] Applied to 6.6/scsi-queue, thanks! [1/1] scsi: ufs: qcom: remove unused variable https://git.kernel.org/mkp/scsi/c/65aca38b8ce7
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 3ee5ff905f9a6..5728e94b6527b 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data) struct msi_desc *desc = data; struct device *dev = msi_desc_to_dev(desc); struct ufs_hba *hba = dev_get_drvdata(dev); - struct ufs_qcom_host *host = ufshcd_get_variant(hba); u32 id = desc->msi_index; struct ufs_hw_queue *hwq = &hba->uhq[id];