| Message ID | 20230724123637.2877393-2-quic_tjiang@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | fail | [v11,1/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066 drivers/bluetooth/hci_qca.c: In function ‘qca_setup’: drivers/bluetooth/hci_qca.c:1767:3: error: ‘soc_name’ undeclared (first use in this function) 1767 | soc_name = "ar300x"; | ^~~~~~~~ drivers/bluetooth/hci_qca.c:1767:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:243: drivers/bluetooth/hci_qca.o] Error 1 make[3]: *** [scripts/Makefile.build:477: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:477: drivers] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/github/workspace/src/src/Makefile:2020: .] Error 2 make: *** [Makefile:234: __sub-make] Error 2 |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=768884
---Test result---
Test Summary:
CheckPatch PASS 1.99 seconds
GitLint PASS 0.67 seconds
SubjectPrefix PASS 0.26 seconds
BuildKernel PASS 33.39 seconds
CheckAllWarning PASS 36.54 seconds
CheckSparse PASS 41.91 seconds
CheckSmatch PASS 113.19 seconds
BuildKernel32 PASS 32.66 seconds
TestRunnerSetup PASS 495.10 seconds
TestRunner_l2cap-tester PASS 23.80 seconds
TestRunner_iso-tester PASS 43.10 seconds
TestRunner_bnep-tester PASS 10.67 seconds
TestRunner_mgmt-tester PASS 218.38 seconds
TestRunner_rfcomm-tester PASS 16.28 seconds
TestRunner_sco-tester PASS 17.17 seconds
TestRunner_ioctl-tester PASS 18.17 seconds
TestRunner_mesh-tester PASS 13.56 seconds
TestRunner_smp-tester PASS 14.64 seconds
TestRunner_userchan-tester PASS 11.27 seconds
IncrementalBuild FAIL 24.28 seconds
Details
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:
[v11,1/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066
drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1767:3: error: ‘soc_name’ undeclared (first use in this function)
1767 | soc_name = "ar300x";
| ^~~~~~~~
drivers/bluetooth/hci_qca.c:1767:3: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [scripts/Makefile.build:243: drivers/bluetooth/hci_qca.o] Error 1
make[3]: *** [scripts/Makefile.build:477: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:477: drivers] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2020: .] Error 2
make: *** [Makefile:234: __sub-make] Error 2
---
Regards,
Linux Bluetooth
diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h index b884095bcd9d..529382f0abb1 100644 --- a/drivers/bluetooth/btqca.h +++ b/drivers/bluetooth/btqca.h @@ -148,6 +148,7 @@ enum qca_btsoc_type { QCA_QCA6390, QCA_WCN6750, QCA_WCN6855, + QCA_QCA2066, }; #if IS_ENABLED(CONFIG_BT_QCA) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 9b785c947d96..ab3a3e11248a 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1762,10 +1762,35 @@ static int qca_setup(struct hci_uart *hu) */ set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks); - bt_dev_info(hdev, "setting up %s", - qca_is_wcn399x(soc_type) ? "wcn399x" : - (soc_type == QCA_WCN6750) ? "wcn6750" : - (soc_type == QCA_WCN6855) ? "wcn6855" : "ROME/QCA6390"); + switch (soc_type) { + case QCA_AR3002: + soc_name = "ar300x"; + break; + case QCA_ROME: + soc_name = "ROME"; + break; + case QCA_WCN3990: + case QCA_WCN3991: + case QCA_WCN3998: + soc_name = "wcn399x"; + break; + case QCA_QCA2066: + soc_name = "QCA2066"; + break; + case QCA_QCA6390: + soc_name = "QCA6390"; + break; + case QCA_WCN6750: + soc_name = "wcn6750"; + break; + case QCA_WCN6855: + soc_name = "wcn6855"; + break; + default: + soc_name = "unknown soc"; + break; + } + bt_dev_info(hdev, "setting up %s", soc_name); qca->memdump_state = QCA_MEMDUMP_IDLE;
This patch make the print btsoc type expression more clearly. Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com> --- drivers/bluetooth/btqca.h | 1 + drivers/bluetooth/hci_qca.c | 33 +++++++++++++++++++++++++++++---- 2 files changed, 30 insertions(+), 4 deletions(-)