| Message ID | 20230714014820.2186203-4-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix IS_ERR() vs NULL check for drm | expand |
Hi Gaosheng, On Fri, Jul 14, 2023 at 09:48:20AM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. > > Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> > --- > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > index 3276a3e82c62..e9c92439398d 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > @@ -259,7 +259,7 @@ komeda_component_get_avail_scaler(struct komeda_component *c, > u32 avail_scalers; > > pipe_st = komeda_pipeline_get_state(c->pipeline, state); > - if (!pipe_st) > + if (IS_ERR(pipe_st)) If you're going to update the other patches to use IS_ERR_OR_NULL() please do so here too. You can keep my R-b for that change. Best regards, Liviu > return NULL; > > avail_scalers = (pipe_st->active_comps & KOMEDA_PIPELINE_SCALERS) ^ > -- > 2.25.1 >
> If you're going to update the other patches to use IS_ERR_OR_NULL() please do so > here too. You can keep my R-b for that change. Thanks for taking time to review the patch. I have update the patch set and add this change to v5. On 2023/7/21 18:24, Liviu Dudau wrote: > Hi Gaosheng, > > On Fri, Jul 14, 2023 at 09:48:20AM +0800, Gaosheng Cui wrote: >> The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should >> use IS_ERR() to check the return value. >> >> Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") >> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> >> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> >> --- >> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c >> index 3276a3e82c62..e9c92439398d 100644 >> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c >> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c >> @@ -259,7 +259,7 @@ komeda_component_get_avail_scaler(struct komeda_component *c, >> u32 avail_scalers; >> >> pipe_st = komeda_pipeline_get_state(c->pipeline, state); >> - if (!pipe_st) >> + if (IS_ERR(pipe_st)) > If you're going to update the other patches to use IS_ERR_OR_NULL() please do so > here too. You can keep my R-b for that change. > > Best regards, > Liviu > >> return NULL; >> >> avail_scalers = (pipe_st->active_comps & KOMEDA_PIPELINE_SCALERS) ^ >> -- >> 2.25.1 >>
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c index 3276a3e82c62..e9c92439398d 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c @@ -259,7 +259,7 @@ komeda_component_get_avail_scaler(struct komeda_component *c, u32 avail_scalers; pipe_st = komeda_pipeline_get_state(c->pipeline, state); - if (!pipe_st) + if (IS_ERR(pipe_st)) return NULL; avail_scalers = (pipe_st->active_comps & KOMEDA_PIPELINE_SCALERS) ^
The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)