mbox series

[PATCHv4,net,0/2] Fix up dev flags when add P2P down link

Message ID 20230721040356.3591174-1-liuhangbin@gmail.com (mailing list archive)
Headers show
Series Fix up dev flags when add P2P down link | expand

Message

Hangbin Liu July 21, 2023, 4:03 a.m. UTC
When adding p2p interfaces to bond/team. The POINTOPOINT, NOARP flags are
not inherit to up devices. Which will trigger IPv6 DAD. Since there is
no ethernet MAC address for P2P devices. This will cause unexpected DAD
failures.

v4: Just reset the team flag, not call ether_setup, as Paolo pointed.
v3: add function team_ether_setup to reset team back to ethernet. Thanks Paolo
v2: Add the missed {} after if checking. Thanks Nikolay.

Hangbin Liu (2):
  bonding: reset bond's flags when down link is P2P device
  team: reset team's flags when down link is P2P device

 drivers/net/bonding/bond_main.c | 5 +++++
 drivers/net/team/team.c         | 9 +++++++++
 2 files changed, 14 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org July 25, 2023, 7:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 21 Jul 2023 12:03:54 +0800 you wrote:
> When adding p2p interfaces to bond/team. The POINTOPOINT, NOARP flags are
> not inherit to up devices. Which will trigger IPv6 DAD. Since there is
> no ethernet MAC address for P2P devices. This will cause unexpected DAD
> failures.
> 
> v4: Just reset the team flag, not call ether_setup, as Paolo pointed.
> v3: add function team_ether_setup to reset team back to ethernet. Thanks Paolo
> v2: Add the missed {} after if checking. Thanks Nikolay.
> 
> [...]

Here is the summary with links:
  - [PATCHv4,net,1/2] bonding: reset bond's flags when down link is P2P device
    https://git.kernel.org/netdev/net/c/da19a2b967cf
  - [PATCHv4,net,2/2] team: reset team's flags when down link is P2P device
    https://git.kernel.org/netdev/net/c/fa532bee17d1

You are awesome, thank you!