diff mbox series

[v2] phy: starfive: make phys depend on HAS_IOMEM

Message ID 20230725063856.482696-1-vkoul@kernel.org
State Accepted
Commit ec6beb82587c73cff52730567016cbc6c17822a8
Headers show
Series [v2] phy: starfive: make phys depend on HAS_IOMEM | expand

Commit Message

Vinod Koul July 25, 2023, 6:38 a.m. UTC
the startfive phy drivers use devm_platform_ioremap_resource() which on
some archs (s390) is not present. So make the drivers depend on HAS_IOMEM

Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/starfive/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Changhuang Liang July 25, 2023, 6:44 a.m. UTC | #1
On 2023/7/25 14:38, Vinod Koul wrote:
> the startfive phy drivers use devm_platform_ioremap_resource() which on
> some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> 
> Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> ---
>  drivers/phy/starfive/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> index a560533a674e..0508f9b123e0 100644
> --- a/drivers/phy/starfive/Kconfig
> +++ b/drivers/phy/starfive/Kconfig
> @@ -5,6 +5,7 @@
>  
>  config PHY_STARFIVE_JH7110_DPHY_RX
>  	tristate "StarFive JH7110 D-PHY RX support"
> +	depends on HAS_IOMEM
>  	select GENERIC_PHY
>  	select GENERIC_PHY_MIPI_DPHY
>  	help
Vinod Koul July 25, 2023, 1:52 p.m. UTC | #2
On Tue, 25 Jul 2023 12:08:56 +0530, Vinod Koul wrote:
> the startfive phy drivers use devm_platform_ioremap_resource() which on
> some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> 
> 

Applied, thanks!

[1/1] phy: starfive: make phys depend on HAS_IOMEM
      commit: ec6beb82587c73cff52730567016cbc6c17822a8

Best regards,
diff mbox series

Patch

diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
index a560533a674e..0508f9b123e0 100644
--- a/drivers/phy/starfive/Kconfig
+++ b/drivers/phy/starfive/Kconfig
@@ -5,6 +5,7 @@ 
 
 config PHY_STARFIVE_JH7110_DPHY_RX
 	tristate "StarFive JH7110 D-PHY RX support"
+	depends on HAS_IOMEM
 	select GENERIC_PHY
 	select GENERIC_PHY_MIPI_DPHY
 	help