| Message ID | 20230725155254.664361-1-eugen.hristev@collabora.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hi, On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote: > The defaults are specified in the description instead of being specified > in the schema. > Fix it by adding the default value in the `default` field. > > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema") > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- Maybe also fix the allowed range while at it? I.e. minimum: 0x00 maximum: 0x7F -- Sebastian > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index bb943c96c196..6d08260ad828 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -92,12 +92,14 @@ properties: > $ref: /schemas/types.yaml#/definitions/phandle > > tx_delay: > - description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default. > + description: Delay value for TXD timing. Range value is 0~0x7F. > $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0x30 > > rx_delay: > - description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default. > + description: Delay value for RXD timing. Range value is 0~0x7F. > $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0x10 > > phy-supply: > description: PHY regulator > -- > 2.34.1 > > > -- > To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
On Tue, Jul 25, 2023 at 06:11:56PM +0200, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote: > > The defaults are specified in the description instead of being specified > > in the schema. > > Fix it by adding the default value in the `default` field. > > > > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema") > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > > --- > > Maybe also fix the allowed range while at it? I.e. > > minimum: 0x00 > maximum: 0x7F Beat me to it! Please do.
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index bb943c96c196..6d08260ad828 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -92,12 +92,14 @@ properties: $ref: /schemas/types.yaml#/definitions/phandle tx_delay: - description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default. + description: Delay value for TXD timing. Range value is 0~0x7F. $ref: /schemas/types.yaml#/definitions/uint32 + default: 0x30 rx_delay: - description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default. + description: Delay value for RXD timing. Range value is 0~0x7F. $ref: /schemas/types.yaml#/definitions/uint32 + default: 0x10 phy-supply: description: PHY regulator
The defaults are specified in the description instead of being specified in the schema. Fix it by adding the default value in the `default` field. Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema") Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)