| Message ID | 20230726143419.19392-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | None | expand |
Pls ignore this, will fix prefix On 2023/7/26 22:34, YueHaibing wrote: > This is not used since commit 3a755cd8b7c6 ("bonding: add new option lacp_active") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > include/net/bond_3ad.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h > index a016f275cb01..c5e57c6bd873 100644 > --- a/include/net/bond_3ad.h > +++ b/include/net/bond_3ad.h > @@ -301,7 +301,6 @@ int __bond_3ad_get_active_agg_info(struct bonding *bond, > int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond, > struct slave *slave); > int bond_3ad_set_carrier(struct bonding *bond); > -void bond_3ad_update_lacp_active(struct bonding *bond); > void bond_3ad_update_lacp_rate(struct bonding *bond); > void bond_3ad_update_ad_actor_settings(struct bonding *bond); > int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats *stats); >
On 7/26/23, YueHaibing <yuehaibing@huawei.com> wrote: > This is not used since commit 3a755cd8b7c6 ("bonding: add new option > lacp_active") To be clear, it appears that the cited commit added the declaration of bond_3ad_upate_lacp_active() to bond_3ad.h, but did not add the actual function definition. A brief search suggests that the function has never existed. Regardless, the declaration shouldn't be there now. Acked-by: Jay Vosburgh <j.vosburgh@gmail.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > include/net/bond_3ad.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h > index a016f275cb01..c5e57c6bd873 100644 > --- a/include/net/bond_3ad.h > +++ b/include/net/bond_3ad.h > @@ -301,7 +301,6 @@ int __bond_3ad_get_active_agg_info(struct bonding > *bond, > int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond, > struct slave *slave); > int bond_3ad_set_carrier(struct bonding *bond); > -void bond_3ad_update_lacp_active(struct bonding *bond); > void bond_3ad_update_lacp_rate(struct bonding *bond); > void bond_3ad_update_ad_actor_settings(struct bonding *bond); > int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats > *stats); > -- > 2.34.1 > >
diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h index a016f275cb01..c5e57c6bd873 100644 --- a/include/net/bond_3ad.h +++ b/include/net/bond_3ad.h @@ -301,7 +301,6 @@ int __bond_3ad_get_active_agg_info(struct bonding *bond, int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond, struct slave *slave); int bond_3ad_set_carrier(struct bonding *bond); -void bond_3ad_update_lacp_active(struct bonding *bond); void bond_3ad_update_lacp_rate(struct bonding *bond); void bond_3ad_update_ad_actor_settings(struct bonding *bond); int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats *stats);
This is not used since commit 3a755cd8b7c6 ("bonding: add new option lacp_active") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- include/net/bond_3ad.h | 1 - 1 file changed, 1 deletion(-)