diff mbox series

arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD

Message ID 20230723-a7sdc2cdnopull-v1-1-699fd730afcb@gerhold.net (mailing list archive)
State Accepted
Commit ee0e92b8e7b5894daf5c94e6433a1989f7233fbe
Headers show
Series arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD | expand

Commit Message

Stephan Gerhold July 23, 2023, 10:54 a.m. UTC 
A7 seems to have external pull-up for the SD card chip detect (like
most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
necessary.

Tested-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 34e472f41d9cd04400b80649ce82cfe11fbe135a
change-id: 20230723-a7sdc2cdnopull-3eb4cadf8f1f

Best regards,

Comments

Konrad Dybcio July 26, 2023, 3:49 p.m. UTC | #1 
On 23.07.2023 12:54, Stephan Gerhold wrote:
> A7 seems to have external pull-up for the SD card chip detect (like
> most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
> necessary.
> 
> Tested-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
If you say so..

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Bjorn Andersson July 28, 2023, 4:08 a.m. UTC | #2 
On Sun, 23 Jul 2023 12:54:41 +0200, Stephan Gerhold wrote:
> A7 seems to have external pull-up for the SD card chip detect (like
> most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
> necessary.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD
      commit: ee0e92b8e7b5894daf5c94e6433a1989f7233fbe

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
index 66e56ac59998..ba652909d162 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
@@ -448,7 +448,7 @@  sdc2_cd_default: sdc2-cd-default-state {
 		pins = "gpio38";
 		function = "gpio";
 		drive-strength = <2>;
-		bias-pull-up;
+		bias-disable;
 	};
 
 	sensor_i2c_default: sensor-i2c-default-state {