| Message ID | 20230726150225.483464-28-herve.codina@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for QMC HDLC, framer infrastruture and PEF2256 framer | expand |
On Wed, Jul 26, 2023 at 05:02:23PM +0200, Herve Codina wrote: > A framer can be connected to the QMC HDLC. > If present, this framer is the interface between the TDM used by the QMC > HDLC and the E1/T1 line. > The QMC HDLC can use this framer to get information about the line and > configure the line. > > Add an optional framer property to reference the framer itself. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> Why not fully describe the hardware in one patch in this series, rather than split this over two different ones? > --- > Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > index 8bb6f34602d9..bf29863ab419 100644 > --- a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > @@ -27,6 +27,11 @@ properties: > Should be a phandle/number pair. The phandle to QMC node and the QMC > channel to use. > > + framer: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle to the framer node > + > required: > - compatible > - fsl,qmc-chan > -- > 2.41.0 >
Hi Conor, On Thu, 27 Jul 2023 09:12:01 +0100 Conor Dooley <conor@kernel.org> wrote: > On Wed, Jul 26, 2023 at 05:02:23PM +0200, Herve Codina wrote: > > A framer can be connected to the QMC HDLC. > > If present, this framer is the interface between the TDM used by the QMC > > HDLC and the E1/T1 line. > > The QMC HDLC can use this framer to get information about the line and > > configure the line. > > > > Add an optional framer property to reference the framer itself. > > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > Why not fully describe the hardware in one patch in this series, rather > than split this over two different ones? I agree, this can be squashed with a previous commit. My intention was to keep things separated in this first series. The framer property makes sense only if the stuff related the generic framer (previous patches) are accepted whereas the QMC HDLC previous binding can be accepted without this framer property. I though it would be easier to review the full series with separated modifications. That's said, I will squash this patch with the patch 5 ("dt-bindings: net: Add support for QMC HDLC") in the next iteration. Best regards, Hervé > > > --- > > Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > index 8bb6f34602d9..bf29863ab419 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > @@ -27,6 +27,11 @@ properties: > > Should be a phandle/number pair. The phandle to QMC node and the QMC > > channel to use. > > > > + framer: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + phandle to the framer node > > + > > required: > > - compatible > > - fsl,qmc-chan > > -- > > 2.41.0 > >
On Wed, Jul 26, 2023 at 05:02:23PM +0200, Herve Codina wrote: > A framer can be connected to the QMC HDLC. > If present, this framer is the interface between the TDM used by the QMC > HDLC and the E1/T1 line. > The QMC HDLC can use this framer to get information about the line and > configure the line. > > Add an optional framer property to reference the framer itself. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > index 8bb6f34602d9..bf29863ab419 100644 > --- a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > @@ -27,6 +27,11 @@ properties: > Should be a phandle/number pair. The phandle to QMC node and the QMC > channel to use. > > + framer: > + $ref: /schemas/types.yaml#/definitions/phandle Now you've defined this property twice. Please avoid doing that. > + description: > + phandle to the framer node > + > required: > - compatible > - fsl,qmc-chan > -- > 2.41.0 >
Hi Rob, On Wed, 2 Aug 2023 18:42:59 -0600 Rob Herring <robh@kernel.org> wrote: > On Wed, Jul 26, 2023 at 05:02:23PM +0200, Herve Codina wrote: > > A framer can be connected to the QMC HDLC. > > If present, this framer is the interface between the TDM used by the QMC > > HDLC and the E1/T1 line. > > The QMC HDLC can use this framer to get information about the line and > > configure the line. > > > > Add an optional framer property to reference the framer itself. > > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > --- > > Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > index 8bb6f34602d9..bf29863ab419 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > @@ -27,6 +27,11 @@ properties: > > Should be a phandle/number pair. The phandle to QMC node and the QMC > > channel to use. > > > > + framer: > > + $ref: /schemas/types.yaml#/definitions/phandle > > Now you've defined this property twice. Please avoid doing that. I don't see what you mean. I previously defined the framer property at the framer-codec node as it is a framer consumer (it was a mistake because this framer-codec node is a child of the framer node but that's an other story). Here, at the qmc-hdlc node, I define this property in order to use the framer as a consumer too. What is wrong ? Best regards, Hervé > > > + description: > > + phandle to the framer node > > + > > required: > > - compatible > > - fsl,qmc-chan > > -- > > 2.41.0 > >
diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml index 8bb6f34602d9..bf29863ab419 100644 --- a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml @@ -27,6 +27,11 @@ properties: Should be a phandle/number pair. The phandle to QMC node and the QMC channel to use. + framer: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the framer node + required: - compatible - fsl,qmc-chan
A framer can be connected to the QMC HDLC. If present, this framer is the interface between the TDM used by the QMC HDLC and the E1/T1 line. The QMC HDLC can use this framer to get information about the line and configure the line. Add an optional framer property to reference the framer itself. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml | 5 +++++ 1 file changed, 5 insertions(+)