| Message ID | 20230727102309.92479-1-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] dt-bindings:iio:frequency:admv1013: add vcc regs | expand |
On 27/07/2023 12:23, Antoniu Miclaus wrote: > Add bindings for the VCC regulators of the ADMV1013 microware > upconverter. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> Subject: missing spaces between prefix parts. > --- > .../bindings/iio/frequency/adi,admv1013.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > index fc813bcb6532..6660299ac1ad 100644 > --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > @@ -39,6 +39,46 @@ properties: > description: > Analog voltage regulator. > > + vcc-drv-supply: > + description: > + RF Driver voltage regulator. > + > + vcc2-drv-supply: > + description: > + RF predriver voltage regulator. > + > + vcc-vva-supply: > + description: > + VVA Control Circuit voltage regulator. > + > + vcc-amp1-supply: > + description: > + RF Amplifier 1 voltage regulator. > + > + vcc-amp2-supply: > + description: > + RF Amplifier 2 voltage regulator. > + > + vcc-env-supply: > + description: > + Envelope Detector voltage regulator. > + > + vcc-bg-supply: > + description: > + Mixer Chip Band Gap Circuit voltage regulator. > + > + vcc-bg2-supply: > + description: > + VGA Chip Band Gap Circuit voltage regulator. > + > + vcc-mixer-supply: > + description: > + Mixer voltage regulator. > + > + vcc-quad-supply: > + description: > + Quadruppler voltage regulator. > + You made them required in the driver, so they should be required here as well. They should be required anyway, because AFAIU they have to be provided. OTOH, this will break the ABI, so your driver might need to take them as optional. Best regards, Krzysztof
On Thu, 27 Jul 2023 12:37:47 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 27/07/2023 12:23, Antoniu Miclaus wrote: > > Add bindings for the VCC regulators of the ADMV1013 microware > > upconverter. > > > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > Subject: missing spaces between prefix parts. > > > --- > > .../bindings/iio/frequency/adi,admv1013.yaml | 50 +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > index fc813bcb6532..6660299ac1ad 100644 > > --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > @@ -39,6 +39,46 @@ properties: > > description: > > Analog voltage regulator. > > > > + vcc-drv-supply: > > + description: > > + RF Driver voltage regulator. > > + > > + vcc2-drv-supply: > > + description: > > + RF predriver voltage regulator. > > + > > + vcc-vva-supply: > > + description: > > + VVA Control Circuit voltage regulator. > > + > > + vcc-amp1-supply: > > + description: > > + RF Amplifier 1 voltage regulator. > > + > > + vcc-amp2-supply: > > + description: > > + RF Amplifier 2 voltage regulator. > > + > > + vcc-env-supply: > > + description: > > + Envelope Detector voltage regulator. > > + > > + vcc-bg-supply: > > + description: > > + Mixer Chip Band Gap Circuit voltage regulator. > > + > > + vcc-bg2-supply: > > + description: > > + VGA Chip Band Gap Circuit voltage regulator. > > + > > + vcc-mixer-supply: > > + description: > > + Mixer voltage regulator. > > + > > + vcc-quad-supply: > > + description: > > + Quadruppler voltage regulator. > > + > > You made them required in the driver, so they should be required here as > well. They should be required anyway, because AFAIU they have to be > provided. > > OTOH, this will break the ABI, so your driver might need to take them as > optional. In many cases will get stub regulators if they aren't explicitly provided, so no breakage and no need to make them optional. Jonathan > > Best regards, > Krzysztof >
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, July 27, 2023 1:38 PM > To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; jic23@kernel.org; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] dt-bindings:iio:frequency:admv1013: add vcc regs > > [External] > > On 27/07/2023 12:23, Antoniu Miclaus wrote: > > Add bindings for the VCC regulators of the ADMV1013 microware > > upconverter. > > > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > Subject: missing spaces between prefix parts. I missed this comment in v2. I will add a v3 fixing the commit subject. > > > --- > > .../bindings/iio/frequency/adi,admv1013.yaml | 50 > +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git > a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > index fc813bcb6532..6660299ac1ad 100644 > > --- > a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > +++ > b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > @@ -39,6 +39,46 @@ properties: > > description: > > Analog voltage regulator. > > > > + vcc-drv-supply: > > + description: > > + RF Driver voltage regulator. > > + > > + vcc2-drv-supply: > > + description: > > + RF predriver voltage regulator. > > + > > + vcc-vva-supply: > > + description: > > + VVA Control Circuit voltage regulator. > > + > > + vcc-amp1-supply: > > + description: > > + RF Amplifier 1 voltage regulator. > > + > > + vcc-amp2-supply: > > + description: > > + RF Amplifier 2 voltage regulator. > > + > > + vcc-env-supply: > > + description: > > + Envelope Detector voltage regulator. > > + > > + vcc-bg-supply: > > + description: > > + Mixer Chip Band Gap Circuit voltage regulator. > > + > > + vcc-bg2-supply: > > + description: > > + VGA Chip Band Gap Circuit voltage regulator. > > + > > + vcc-mixer-supply: > > + description: > > + Mixer voltage regulator. > > + > > + vcc-quad-supply: > > + description: > > + Quadruppler voltage regulator. > > + > > You made them required in the driver, so they should be required here as > well. They should be required anyway, because AFAIU they have to be > provided. > > OTOH, this will break the ABI, so your driver might need to take them as > optional. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml index fc813bcb6532..6660299ac1ad 100644 --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml @@ -39,6 +39,46 @@ properties: description: Analog voltage regulator. + vcc-drv-supply: + description: + RF Driver voltage regulator. + + vcc2-drv-supply: + description: + RF predriver voltage regulator. + + vcc-vva-supply: + description: + VVA Control Circuit voltage regulator. + + vcc-amp1-supply: + description: + RF Amplifier 1 voltage regulator. + + vcc-amp2-supply: + description: + RF Amplifier 2 voltage regulator. + + vcc-env-supply: + description: + Envelope Detector voltage regulator. + + vcc-bg-supply: + description: + Mixer Chip Band Gap Circuit voltage regulator. + + vcc-bg2-supply: + description: + VGA Chip Band Gap Circuit voltage regulator. + + vcc-mixer-supply: + description: + Mixer voltage regulator. + + vcc-quad-supply: + description: + Quadruppler voltage regulator. + adi,detector-enable: description: Enable the Envelope Detector available at output pins VENV_P and @@ -87,6 +127,16 @@ examples: clocks = <&admv1013_lo>; clock-names = "lo_in"; vcm-supply = <&vcm>; + vcc-drv-supply = <&vcc_drv>; + vcc2-drv-supply = <&vcc2_drv>; + vcc-vva-supply = <&vcc_vva>; + vcc-amp1-supply = <&vcc_amp1>; + vcc-amp2-supply = <&vcc_amp2>; + vcc-env-supply = <&vcc_env>; + vcc-bg-supply = <&vcc_bg>; + vcc-bg2-supply = <&vcc_bg2>; + vcc-mixer-supply = <&vcc_mixer>; + vcc-quad-supply = <&vcc_quad>; adi,quad-se-mode = "diff"; adi,detector-enable; };
Add bindings for the VCC regulators of the ADMV1013 microware upconverter. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- .../bindings/iio/frequency/adi,admv1013.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+)