diff mbox series

[v2] net: remove comment in ndisc_router_discovery

Message ID 20230726184742.342825-1-prohr@google.com (mailing list archive)
State Accepted
Commit ef27ba5c845d22de79447d7da8e12471168a8e77
Delegated to: Netdev Maintainers
Headers show
Series [v2] net: remove comment in ndisc_router_discovery | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1343 this patch: 1343
netdev/cc_maintainers warning 4 maintainers not CCed: kuba@kernel.org dsahern@kernel.org edumazet@google.com pabeni@redhat.com
netdev/build_clang success Errors and warnings before: 1365 this patch: 1365
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1365 this patch: 1365
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Patrick Rohr July 26, 2023, 6:47 p.m. UTC
Removes superfluous (and misplaced) comment from ndisc_router_discovery.

Signed-off-by: Patrick Rohr <prohr@google.com>
---
 net/ipv6/ndisc.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Simon Horman July 27, 2023, 12:04 p.m. UTC | #1
On Wed, Jul 26, 2023 at 11:47:42AM -0700, Patrick Rohr wrote:
> Removes superfluous (and misplaced) comment from ndisc_router_discovery.
> 
> Signed-off-by: Patrick Rohr <prohr@google.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
David Ahern July 27, 2023, 3:18 p.m. UTC | #2
On 7/26/23 12:47 PM, Patrick Rohr wrote:
> Removes superfluous (and misplaced) comment from ndisc_router_discovery.
> 
> Signed-off-by: Patrick Rohr <prohr@google.com>
> ---
>  net/ipv6/ndisc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>
patchwork-bot+netdevbpf@kernel.org July 28, 2023, 12:10 a.m. UTC | #3
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 26 Jul 2023 11:47:42 -0700 you wrote:
> Removes superfluous (and misplaced) comment from ndisc_router_discovery.
> 
> Signed-off-by: Patrick Rohr <prohr@google.com>
> ---
>  net/ipv6/ndisc.c | 4 ----
>  1 file changed, 4 deletions(-)

Here is the summary with links:
  - [v2] net: remove comment in ndisc_router_discovery
    https://git.kernel.org/netdev/net-next/c/ef27ba5c845d

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index eeb60888187f..c394799be38f 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1266,10 +1266,6 @@  static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
 	}
 #endif
 
-	/*
-	 *	set the RA_RECV flag in the interface
-	 */
-
 	in6_dev = __in6_dev_get(skb->dev);
 	if (!in6_dev) {
 		ND_PRINTK(0, err, "RA: can't find inet6 device for %s\n",