diff mbox series

[v3,2/3] ARM: dts: imx6sx: Describe the default LCDIF1 parent

Message ID 20230712115301.690714-2-festevam@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show
Series [v3,1/3] ARM: dts: imx6sx: Remove LDB endpoint | expand

Commit Message

Fabio Estevam July 12, 2023, 11:53 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

A suitable default for the LCDIF parent is the PLL5 clock, so
describe it in the device tree.

The imx6sx clock driver harcodes PLL5 as the LCDIF1 parent, but
in preparation for removing such hardcoding, describe the parent
relationship via devicetree.

There are some boards that may want to use a different parent
for the LCDIF due to EMI reasons, for example.

With this approch, the user can change the LCDIF parent in the board
devicetree if needed.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v2:
- Rebased against 6.5-rc1.

 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Shawn Guo July 30, 2023, 3:13 a.m. UTC | #1 
On Wed, Jul 12, 2023 at 08:53:00AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> A suitable default for the LCDIF parent is the PLL5 clock, so
> describe it in the device tree.
> 
> The imx6sx clock driver harcodes PLL5 as the LCDIF1 parent, but
> in preparation for removing such hardcoding, describe the parent
> relationship via devicetree.
> 
> There are some boards that may want to use a different parent
> for the LCDIF due to EMI reasons, for example.
> 
> With this approch, the user can change the LCDIF parent in the board
> devicetree if needed.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
index 41c900929758..0d549e1f3ced 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
@@ -1305,6 +1305,10 @@  lcdif1: lcdif@2220000 {
 						 <&clks IMX6SX_CLK_LCDIF_APB>,
 						 <&clks IMX6SX_CLK_DISPLAY_AXI>;
 					clock-names = "pix", "axi", "disp_axi";
+					assigned-clocks = <&clks IMX6SX_CLK_LCDIF1_PRE_SEL>,
+							  <&clks IMX6SX_CLK_LCDIF1_SEL>;
+					assigned-clock-parents = <&clks IMX6SX_CLK_PLL5_VIDEO_DIV>,
+								 <&clks IMX6SX_CLK_LCDIF1_PODF>;
 					power-domains = <&pd_disp>;
 					status = "disabled";