| Message ID | 20230729121929.17180-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4cbc32a8a2b44fc7e91ae3006e5da3eaf630e383 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/smc: Remove unused function declarations | expand |
On Sat, Jul 29, 2023 at 08:19:29PM +0800, Yue Haibing wrote: > commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()") > left behind smc_lgr_schedule_free_work_fast() declaration. > And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock") > smc_ib_modify_qp_reset() is not used anymore. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Sat, Jul 29, 2023 at 08:19:29PM +0800, Yue Haibing wrote: > commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()") > left behind smc_lgr_schedule_free_work_fast() declaration. > And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock") > smc_ib_modify_qp_reset() is not used anymore. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> LGTM, thanks. Reviewed-by: Tony Lu <tonylu@linux.alibaba.com> > --- > net/smc/smc_core.h | 1 - > net/smc/smc_ib.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/net/smc/smc_core.h b/net/smc/smc_core.h > index 1645fba0d2d3..3c1b31bfa1cf 100644 > --- a/net/smc/smc_core.h > +++ b/net/smc/smc_core.h > @@ -539,7 +539,6 @@ int smc_vlan_by_tcpsk(struct socket *clcsock, struct smc_init_info *ini); > > void smc_conn_free(struct smc_connection *conn); > int smc_conn_create(struct smc_sock *smc, struct smc_init_info *ini); > -void smc_lgr_schedule_free_work_fast(struct smc_link_group *lgr); > int smc_core_init(void); > void smc_core_exit(void); > > diff --git a/net/smc/smc_ib.h b/net/smc/smc_ib.h > index 034295676e88..4df5f8c8a0a1 100644 > --- a/net/smc/smc_ib.h > +++ b/net/smc/smc_ib.h > @@ -96,7 +96,6 @@ void smc_ib_destroy_queue_pair(struct smc_link *lnk); > int smc_ib_create_queue_pair(struct smc_link *lnk); > int smc_ib_ready_link(struct smc_link *lnk); > int smc_ib_modify_qp_rts(struct smc_link *lnk); > -int smc_ib_modify_qp_reset(struct smc_link *lnk); > int smc_ib_modify_qp_error(struct smc_link *lnk); > long smc_ib_setup_per_ibdev(struct smc_ib_device *smcibdev); > int smc_ib_get_memory_region(struct ib_pd *pd, int access_flags, > -- > 2.34.1
On 29.07.23 14:19, Yue Haibing wrote: > commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()") > left behind smc_lgr_schedule_free_work_fast() declaration. > And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock") > smc_ib_modify_qp_reset() is not used anymore. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Thank you for the findings! Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 29 Jul 2023 20:19:29 +0800 you wrote: > commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()") > left behind smc_lgr_schedule_free_work_fast() declaration. > And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock") > smc_ib_modify_qp_reset() is not used anymore. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > > [...] Here is the summary with links: - [net-next] net/smc: Remove unused function declarations https://git.kernel.org/netdev/net-next/c/4cbc32a8a2b4 You are awesome, thank you!
diff --git a/net/smc/smc_core.h b/net/smc/smc_core.h index 1645fba0d2d3..3c1b31bfa1cf 100644 --- a/net/smc/smc_core.h +++ b/net/smc/smc_core.h @@ -539,7 +539,6 @@ int smc_vlan_by_tcpsk(struct socket *clcsock, struct smc_init_info *ini); void smc_conn_free(struct smc_connection *conn); int smc_conn_create(struct smc_sock *smc, struct smc_init_info *ini); -void smc_lgr_schedule_free_work_fast(struct smc_link_group *lgr); int smc_core_init(void); void smc_core_exit(void); diff --git a/net/smc/smc_ib.h b/net/smc/smc_ib.h index 034295676e88..4df5f8c8a0a1 100644 --- a/net/smc/smc_ib.h +++ b/net/smc/smc_ib.h @@ -96,7 +96,6 @@ void smc_ib_destroy_queue_pair(struct smc_link *lnk); int smc_ib_create_queue_pair(struct smc_link *lnk); int smc_ib_ready_link(struct smc_link *lnk); int smc_ib_modify_qp_rts(struct smc_link *lnk); -int smc_ib_modify_qp_reset(struct smc_link *lnk); int smc_ib_modify_qp_error(struct smc_link *lnk); long smc_ib_setup_per_ibdev(struct smc_ib_device *smcibdev); int smc_ib_get_memory_region(struct ib_pd *pd, int access_flags,
commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()") left behind smc_lgr_schedule_free_work_fast() declaration. And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock") smc_ib_modify_qp_reset() is not used anymore. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- net/smc/smc_core.h | 1 - net/smc/smc_ib.h | 1 - 2 files changed, 2 deletions(-)