| Message ID | 20230731061325.26431-6-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | soc: qcom: Add support for SM4450 | expand |
On 31/07/2023 08:13, Tengfei Fan wrote: > Adjust the position of QCOM_ID_QDU1010, so that there is a coherent > sequence of numbers. > > Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > --- > include/dt-bindings/arm/qcom,ids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h > index bcbe9ee2cdaf..977c235ed0d9 100644 > --- a/include/dt-bindings/arm/qcom,ids.h > +++ b/include/dt-bindings/arm/qcom,ids.h > @@ -249,8 +249,8 @@ > #define QCOM_ID_SA8775P 534 > #define QCOM_ID_QRU1000 539 > #define QCOM_ID_QDU1000 545 > -#define QCOM_ID_QDU1010 587 > #define QCOM_ID_IPQ5019 569 I don't think this change is needed. Isn't IPQ5019 going away? Best regards, Krzysztof
在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道: > On 31/07/2023 08:13, Tengfei Fan wrote: >> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent >> sequence of numbers. >> >> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 > > Please run scripts/checkpatch.pl and fix reported warnings. Some > warnings can be ignored, but the code here looks like it needs a fix. > Feel free to get in touch if the warning is not clear. > sure, will do this check if this patch still need. >> --- >> include/dt-bindings/arm/qcom,ids.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h >> index bcbe9ee2cdaf..977c235ed0d9 100644 >> --- a/include/dt-bindings/arm/qcom,ids.h >> +++ b/include/dt-bindings/arm/qcom,ids.h >> @@ -249,8 +249,8 @@ >> #define QCOM_ID_SA8775P 534 >> #define QCOM_ID_QRU1000 539 >> #define QCOM_ID_QDU1000 545 >> -#define QCOM_ID_QDU1010 587 >> #define QCOM_ID_IPQ5019 569 > > I don't think this change is needed. Isn't IPQ5019 going away? Will remove this patch, another is handling this: https://lore.kernel.org/lkml/20230724083745.1015321-1-quic_kathirav@quicinc.com/T/ > > > Best regards, > Krzysztof >
On 31/07/2023 09:21, Tengfei Fan wrote: > > > 在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道: >> On 31/07/2023 08:13, Tengfei Fan wrote: >>> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent >>> sequence of numbers. >>> >>> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 >> >> Please run scripts/checkpatch.pl and fix reported warnings. Some >> warnings can be ignored, but the code here looks like it needs a fix. >> Feel free to get in touch if the warning is not clear. >> > sure, will do this check if this patch still need. I understand that resending this might not be needed, but just to clarify: you must run checkpatch on all your patches before sending them. This is the most basic step required before sending anything. Best regards, Krzysztof
在 7/31/2023 4:02 PM, Krzysztof Kozlowski 写道: > On 31/07/2023 09:21, Tengfei Fan wrote: >> >> >> 在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道: >>> On 31/07/2023 08:13, Tengfei Fan wrote: >>>> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent >>>> sequence of numbers. >>>> >>>> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 >>> >>> Please run scripts/checkpatch.pl and fix reported warnings. Some >>> warnings can be ignored, but the code here looks like it needs a fix. >>> Feel free to get in touch if the warning is not clear. >>> >> sure, will do this check if this patch still need. > > I understand that resending this might not be needed, but just to > clarify: you must run checkpatch on all your patches before sending > them. This is the most basic step required before sending anything. > > Best regards, > Krzysztof > Thanks Krzysztof remind me kindly, will do checkpatch confirm if have other patch need push to upstream. new patcheset already remove this patch, and already got your review, Thanks again!
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h index bcbe9ee2cdaf..977c235ed0d9 100644 --- a/include/dt-bindings/arm/qcom,ids.h +++ b/include/dt-bindings/arm/qcom,ids.h @@ -249,8 +249,8 @@ #define QCOM_ID_SA8775P 534 #define QCOM_ID_QRU1000 539 #define QCOM_ID_QDU1000 545 -#define QCOM_ID_QDU1010 587 #define QCOM_ID_IPQ5019 569 +#define QCOM_ID_QDU1010 587 #define QCOM_ID_QRU1032 588 #define QCOM_ID_QRU1052 589 #define QCOM_ID_QRU1062 590