| Message ID | 20230731055932.4336-1-TonyWWang-oc@zhaoxin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda: Zhaoxin: Add HDAC PCI IDs and HDMI Codec Vendor IDs | expand |
On Mon, 31 Jul 2023 07:59:32 +0200, Tony W Wang-oc wrote: > @@ -1044,6 +1044,16 @@ void azx_stop_chip(struct azx *chip) > } > EXPORT_SYMBOL_GPL(azx_stop_chip); > > +static void azx_rirb_zxdelay(struct azx *chip, int enable) It'd be helpful to have a brief function description. It doesn't do any delaying but flip something instead, right? > +{ > + if (chip->remap_diu_addr) { > + if (!enable) > + writel(0x0, (char *)chip->remap_diu_addr + 0x490a8); > + else > + writel(0x1000000, (char *)chip->remap_diu_addr + 0x490a8); Avoid magic numbers, but define them. > @@ -1103,9 +1113,14 @@ irqreturn_t azx_interrupt(int irq, void *dev_id) > azx_writeb(chip, RIRBSTS, RIRB_INT_MASK); > active = true; > if (status & RIRB_INT_RESPONSE) { > - if (chip->driver_caps & AZX_DCAPS_CTX_WORKAROUND) > + if ((chip->driver_caps & AZX_DCAPS_CTX_WORKAROUND) || > + (chip->driver_caps & AZX_DCAPS_RIRB_PRE_DELAY)) { > + azx_rirb_zxdelay(chip, 1); > udelay(80); Calling it here looks a bit misleading, especially because it's paired with a later call. Better to put another if block that matches with both calls consistently. > + } > snd_hdac_bus_update_rirb(bus); > + if (chip->driver_caps & AZX_DCAPS_RIRB_PRE_DELAY) > + azx_rirb_zxdelay(chip, 0); I meant this one. > @@ -145,6 +146,7 @@ struct azx { > > /* GTS present */ > unsigned int gts_present:1; > + void __iomem *remap_diu_addr; This is a completely different thing, give some comment. > +static int azx_init_pci_zx(struct azx *chip) > +{ > + struct snd_card *card = chip->card; > + unsigned int diu_reg; > + struct pci_dev *diu_pci = NULL; > + > + diu_pci = pci_get_device(PCI_VENDOR_ID_ZHAOXIN, 0x3a03, NULL); > + if (!diu_pci) { > + dev_err(card->dev, "hda no KX-5000 device.\n"); > + return -ENXIO; > + } > + pci_read_config_dword(diu_pci, PCI_BASE_ADDRESS_0, &diu_reg); > + chip->remap_diu_addr = ioremap(diu_reg, 0x50000); > + dev_info(card->dev, "hda %x %p\n", diu_reg, chip->remap_diu_addr); > + return 0; Missing pci_dev_put()? > @@ -1360,6 +1385,10 @@ static void azx_free(struct azx *chip) > hda->init_failed = 1; /* to be sure */ > complete_all(&hda->probe_wait); > > + if (chip->driver_type == AZX_DRIVER_ZHAOXINHDMI) { > + azx_free_pci_zx(chip); > + } Superfluous parentheses. > @@ -1876,6 +1906,10 @@ static int azx_first_init(struct azx *chip) > bus->access_sdnctl_in_dword = 1; > } > > + chip->remap_diu_addr = NULL; > + if (chip->driver_type == AZX_DRIVER_ZHAOXINHDMI) > + azx_init_pci_zx(chip); No error check? It doesn't look too serious even if the driver continues to load, though. > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -4501,6 +4501,8 @@ static int patch_gf_hdmi(struct hda_codec *codec) > return 0; > } > > +static int patch_zx_hdmi(struct hda_codec *codec) { return patch_gf_hdmi(codec); } Don't put in a single line. Or, if it's the very same function, you can rather call patch_gf_hdmi directly in the table. thanks, Takashi
On 7/31/23 15:48, Takashi Iwai wrote: > On Mon, 31 Jul 2023 07:59:32 +0200, > Tony W Wang-oc wrote: >> @@ -1044,6 +1044,16 @@ void azx_stop_chip(struct azx *chip) >> } >> EXPORT_SYMBOL_GPL(azx_stop_chip); >> >> +static void azx_rirb_zxdelay(struct azx *chip, int enable) > > It'd be helpful to have a brief function description. It doesn't do > any delaying but flip something instead, right? Yes, you are right. This function expects to implement two functions: Adjust the priority of write cycles for KX-5000 and delay some time. Now its only implement the first function. > >> +{ >> + if (chip->remap_diu_addr) { >> + if (!enable) >> + writel(0x0, (char *)chip->remap_diu_addr + 0x490a8); >> + else >> + writel(0x1000000, (char *)chip->remap_diu_addr + 0x490a8); > > Avoid magic numbers, but define them. > Got it. This solution operate the register inside the GPU witch do not belong to HDAC. So will evaluate this patch method again. >> @@ -1103,9 +1113,14 @@ irqreturn_t azx_interrupt(int irq, void *dev_id) >> azx_writeb(chip, RIRBSTS, RIRB_INT_MASK); >> active = true; >> if (status & RIRB_INT_RESPONSE) { >> - if (chip->driver_caps & AZX_DCAPS_CTX_WORKAROUND) >> + if ((chip->driver_caps & AZX_DCAPS_CTX_WORKAROUND) || >> + (chip->driver_caps & AZX_DCAPS_RIRB_PRE_DELAY)) { >> + azx_rirb_zxdelay(chip, 1); >> udelay(80); > > Calling it here looks a bit misleading, especially because it's paired > with a later call. Better to put another if block that matches with > both calls consistently. > Ok. >> + } >> snd_hdac_bus_update_rirb(bus); >> + if (chip->driver_caps & AZX_DCAPS_RIRB_PRE_DELAY) >> + azx_rirb_zxdelay(chip, 0); > > I meant this one. > >> @@ -145,6 +146,7 @@ struct azx { >> >> /* GTS present */ >> unsigned int gts_present:1; >> + void __iomem *remap_diu_addr; > > This is a completely different thing, give some comment. > Its belong to GPU MMIO. > >> +static int azx_init_pci_zx(struct azx *chip) >> +{ >> + struct snd_card *card = chip->card; >> + unsigned int diu_reg; >> + struct pci_dev *diu_pci = NULL; >> + >> + diu_pci = pci_get_device(PCI_VENDOR_ID_ZHAOXIN, 0x3a03, NULL); >> + if (!diu_pci) { >> + dev_err(card->dev, "hda no KX-5000 device.\n"); >> + return -ENXIO; >> + } >> + pci_read_config_dword(diu_pci, PCI_BASE_ADDRESS_0, &diu_reg); >> + chip->remap_diu_addr = ioremap(diu_reg, 0x50000); >> + dev_info(card->dev, "hda %x %p\n", diu_reg, chip->remap_diu_addr); >> + return 0; > > Missing pci_dev_put()? > Yes. >> @@ -1360,6 +1385,10 @@ static void azx_free(struct azx *chip) >> hda->init_failed = 1; /* to be sure */ >> complete_all(&hda->probe_wait); >> >> + if (chip->driver_type == AZX_DRIVER_ZHAOXINHDMI) { >> + azx_free_pci_zx(chip); >> + } > > Superfluous parentheses. > >> @@ -1876,6 +1906,10 @@ static int azx_first_init(struct azx *chip) >> bus->access_sdnctl_in_dword = 1; >> } >> >> + chip->remap_diu_addr = NULL; >> + if (chip->driver_type == AZX_DRIVER_ZHAOXINHDMI) >> + azx_init_pci_zx(chip); > > No error check? It doesn't look too serious even if the driver > continues to load, though. > >> --- a/sound/pci/hda/patch_hdmi.c >> +++ b/sound/pci/hda/patch_hdmi.c >> @@ -4501,6 +4501,8 @@ static int patch_gf_hdmi(struct hda_codec *codec) >> return 0; >> } >> >> +static int patch_zx_hdmi(struct hda_codec *codec) { return patch_gf_hdmi(codec); } > > Don't put in a single line. > Or, if it's the very same function, you can rather call patch_gf_hdmi > directly in the table. > Ok. > > thanks, > > Takashi
Hi Tony, kernel test robot noticed the following build warnings: [auto build test WARNING on tiwai-sound/for-next] [also build test WARNING on next-20230802] [cannot apply to tiwai-sound/for-linus linus/master v6.5-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tony-W-Wang-oc/ALSA-hda-Zhaoxin-Add-HDAC-PCI-IDs-and-HDMI-Codec-Vendor-IDs/20230731-140118 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20230731055932.4336-1-TonyWWang-oc%40zhaoxin.com patch subject: [PATCH] ALSA: hda: Zhaoxin: Add HDAC PCI IDs and HDMI Codec Vendor IDs config: nios2-randconfig-r093-20230730 (https://download.01.org/0day-ci/archive/20230803/202308030402.Y1yMDGnZ-lkp@intel.com/config) compiler: nios2-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230803/202308030402.Y1yMDGnZ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308030402.Y1yMDGnZ-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/pci/hda/hda_controller.c:1051:38: sparse: sparse: cast removes address space '__iomem' of expression >> sound/pci/hda/hda_controller.c:1051:66: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got char * @@ sound/pci/hda/hda_controller.c:1051:66: sparse: expected void volatile [noderef] __iomem *addr sound/pci/hda/hda_controller.c:1051:66: sparse: got char * sound/pci/hda/hda_controller.c:1053:44: sparse: sparse: cast removes address space '__iomem' of expression sound/pci/hda/hda_controller.c:1053:72: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got char * @@ sound/pci/hda/hda_controller.c:1053:72: sparse: expected void volatile [noderef] __iomem *addr sound/pci/hda/hda_controller.c:1053:72: sparse: got char * vim +/__iomem +1051 sound/pci/hda/hda_controller.c 1046 1047 static void azx_rirb_zxdelay(struct azx *chip, int enable) 1048 { 1049 if (chip->remap_diu_addr) { 1050 if (!enable) > 1051 writel(0x0, (char *)chip->remap_diu_addr + 0x490a8); 1052 else 1053 writel(0x1000000, (char *)chip->remap_diu_addr + 0x490a8); 1054 } 1055 } 1056
Hi Tony, kernel test robot noticed the following build warnings: [auto build test WARNING on tiwai-sound/for-next] [also build test WARNING on next-20230809] [cannot apply to tiwai-sound/for-linus linus/master v6.5-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tony-W-Wang-oc/ALSA-hda-Zhaoxin-Add-HDAC-PCI-IDs-and-HDMI-Codec-Vendor-IDs/20230731-140118 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20230731055932.4336-1-TonyWWang-oc%40zhaoxin.com patch subject: [PATCH] ALSA: hda: Zhaoxin: Add HDAC PCI IDs and HDMI Codec Vendor IDs config: mips-randconfig-r073-20230814 (https://download.01.org/0day-ci/archive/20230814/202308140952.khPgynBT-lkp@intel.com/config) compiler: mips64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230814/202308140952.khPgynBT-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308140952.khPgynBT-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) sound/pci/hda/hda_controller.c:1051:38: sparse: sparse: cast removes address space '__iomem' of expression >> sound/pci/hda/hda_controller.c:1051:66: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got char * @@ sound/pci/hda/hda_controller.c:1051:66: sparse: expected void volatile [noderef] __iomem *mem sound/pci/hda/hda_controller.c:1051:66: sparse: got char * sound/pci/hda/hda_controller.c:1053:44: sparse: sparse: cast removes address space '__iomem' of expression sound/pci/hda/hda_controller.c:1053:72: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got char * @@ sound/pci/hda/hda_controller.c:1053:72: sparse: expected void volatile [noderef] __iomem *mem sound/pci/hda/hda_controller.c:1053:72: sparse: got char * vim +1051 sound/pci/hda/hda_controller.c 1046 1047 static void azx_rirb_zxdelay(struct azx *chip, int enable) 1048 { 1049 if (chip->remap_diu_addr) { 1050 if (!enable) > 1051 writel(0x0, (char *)chip->remap_diu_addr + 0x490a8); 1052 else 1053 writel(0x1000000, (char *)chip->remap_diu_addr + 0x490a8); 1054 } 1055 } 1056
diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c index 406779625fb5..7b7a7735c482 100644 --- a/sound/pci/hda/hda_controller.c +++ b/sound/pci/hda/hda_controller.c @@ -1044,6 +1044,16 @@ void azx_stop_chip(struct azx *chip) } EXPORT_SYMBOL_GPL(azx_stop_chip); +static void azx_rirb_zxdelay(struct azx *chip, int enable) +{ + if (chip->remap_diu_addr) { + if (!enable) + writel(0x0, (char *)chip->remap_diu_addr + 0x490a8); + else + writel(0x1000000, (char *)chip->remap_diu_addr + 0x490a8); + } +} + /* * interrupt handler */ @@ -1103,9 +1113,14 @@ irqreturn_t azx_interrupt(int irq, void *dev_id) azx_writeb(chip, RIRBSTS, RIRB_INT_MASK); active = true; if (status & RIRB_INT_RESPONSE) { - if (chip->driver_caps & AZX_DCAPS_CTX_WORKAROUND) + if ((chip->driver_caps & AZX_DCAPS_CTX_WORKAROUND) || + (chip->driver_caps & AZX_DCAPS_RIRB_PRE_DELAY)) { + azx_rirb_zxdelay(chip, 1); udelay(80); + } snd_hdac_bus_update_rirb(bus); + if (chip->driver_caps & AZX_DCAPS_RIRB_PRE_DELAY) + azx_rirb_zxdelay(chip, 0); } } } while (active && ++repeat < 10); diff --git a/sound/pci/hda/hda_controller.h b/sound/pci/hda/hda_controller.h index 8556031bcd68..ba51e33329c1 100644 --- a/sound/pci/hda/hda_controller.h +++ b/sound/pci/hda/hda_controller.h @@ -45,6 +45,7 @@ #define AZX_DCAPS_CORBRP_SELF_CLEAR (1 << 28) /* CORBRP clears itself after reset */ #define AZX_DCAPS_NO_MSI64 (1 << 29) /* Stick to 32-bit MSIs */ #define AZX_DCAPS_SEPARATE_STREAM_TAG (1 << 30) /* capture and playback use separate stream tag */ +#define AZX_DCAPS_RIRB_PRE_DELAY (1 << 31) /* RIRB need delay */ enum { AZX_SNOOP_TYPE_NONE, @@ -145,6 +146,7 @@ struct azx { /* GTS present */ unsigned int gts_present:1; + void __iomem *remap_diu_addr; #ifdef CONFIG_SND_HDA_DSP_LOADER struct azx_dev saved_azx_dev; diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 176567f0d0e0..d5dce7e7ef4a 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -238,6 +238,7 @@ enum { AZX_DRIVER_CMEDIA, AZX_DRIVER_ZHAOXIN, AZX_DRIVER_LOONGSON, + AZX_DRIVER_ZHAOXINHDMI, AZX_DRIVER_GENERIC, AZX_NUM_DRIVERS, /* keep this as last entry */ }; @@ -350,6 +351,7 @@ static const char * const driver_short_names[] = { [AZX_DRIVER_CMEDIA] = "HDA C-Media", [AZX_DRIVER_ZHAOXIN] = "HDA Zhaoxin", [AZX_DRIVER_LOONGSON] = "HDA Loongson", + [AZX_DRIVER_ZHAOXINHDMI] = "HDA Zhaoxin HDMI", [AZX_DRIVER_GENERIC] = "HD-Audio Generic", }; @@ -371,6 +373,29 @@ static void update_pci_byte(struct pci_dev *pci, unsigned int reg, pci_write_config_byte(pci, reg, data); } +static int azx_init_pci_zx(struct azx *chip) +{ + struct snd_card *card = chip->card; + unsigned int diu_reg; + struct pci_dev *diu_pci = NULL; + + diu_pci = pci_get_device(PCI_VENDOR_ID_ZHAOXIN, 0x3a03, NULL); + if (!diu_pci) { + dev_err(card->dev, "hda no KX-5000 device.\n"); + return -ENXIO; + } + pci_read_config_dword(diu_pci, PCI_BASE_ADDRESS_0, &diu_reg); + chip->remap_diu_addr = ioremap(diu_reg, 0x50000); + dev_info(card->dev, "hda %x %p\n", diu_reg, chip->remap_diu_addr); + return 0; +} + +static void azx_free_pci_zx(struct azx *chip) +{ + if (chip->remap_diu_addr) + iounmap(chip->remap_diu_addr); +} + static void azx_init_pci(struct azx *chip) { int snoop_type = azx_get_snoop_type(chip); @@ -1360,6 +1385,10 @@ static void azx_free(struct azx *chip) hda->init_failed = 1; /* to be sure */ complete_all(&hda->probe_wait); + if (chip->driver_type == AZX_DRIVER_ZHAOXINHDMI) { + azx_free_pci_zx(chip); + } + if (use_vga_switcheroo(hda)) { if (chip->disabled && hda->probe_continued) snd_hda_unlock_devices(&chip->bus); @@ -1743,10 +1772,11 @@ static int default_bdl_pos_adj(struct azx *chip) switch (chip->driver_type) { /* - * increase the bdl size for Glenfly Gpus for hardware + * increase the bdl size for Glenfly/Zhaoxin Gpus for hardware * limitation on hdac interrupt interval */ case AZX_DRIVER_GFHDMI: + case AZX_DRIVER_ZHAOXINHDMI: return 128; case AZX_DRIVER_ICH: case AZX_DRIVER_PCH: @@ -1876,6 +1906,10 @@ static int azx_first_init(struct azx *chip) bus->access_sdnctl_in_dword = 1; } + chip->remap_diu_addr = NULL; + if (chip->driver_type == AZX_DRIVER_ZHAOXINHDMI) + azx_init_pci_zx(chip); + err = pcim_iomap_regions(pci, 1 << 0, "ICH HD audio"); if (err < 0) return err; @@ -1977,6 +2011,7 @@ static int azx_first_init(struct azx *chip) chip->capture_streams = ATIHDMI_NUM_CAPTURE; break; case AZX_DRIVER_GFHDMI: + case AZX_DRIVER_ZHAOXINHDMI: case AZX_DRIVER_GENERIC: default: chip->playback_streams = ICH6_NUM_PLAYBACK; @@ -2739,6 +2774,20 @@ static const struct pci_device_id azx_ids[] = { .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_HDMI }, /* Zhaoxin */ { PCI_VDEVICE(ZHAOXIN, 0x3288), .driver_data = AZX_DRIVER_ZHAOXIN }, + { PCI_VDEVICE(ZHAOXIN, 0x9141), + .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_NO_64BIT }, + { PCI_VDEVICE(ZHAOXIN, 0x9142), + .driver_data = AZX_DRIVER_ZHAOXINHDMI | AZX_DCAPS_POSFIX_LPIB | + AZX_DCAPS_NO_MSI | AZX_DCAPS_RIRB_PRE_DELAY | AZX_DCAPS_NO_64BIT }, + { PCI_VDEVICE(ZHAOXIN, 0x9144), + .driver_data = AZX_DRIVER_ZHAOXINHDMI | AZX_DCAPS_POSFIX_LPIB | + AZX_DCAPS_NO_MSI | AZX_DCAPS_RIRB_PRE_DELAY | AZX_DCAPS_NO_64BIT }, + { PCI_VDEVICE(ZHAOXIN, 0x9145), + .driver_data = AZX_DRIVER_ZHAOXINHDMI | AZX_DCAPS_POSFIX_LPIB | + AZX_DCAPS_NO_MSI | AZX_DCAPS_RIRB_PRE_DELAY | AZX_DCAPS_NO_64BIT }, + { PCI_VDEVICE(ZHAOXIN, 0x9146), + .driver_data = AZX_DRIVER_ZHAOXINHDMI | AZX_DCAPS_POSFIX_LPIB | + AZX_DCAPS_NO_MSI | AZX_DCAPS_RIRB_PRE_DELAY | AZX_DCAPS_NO_64BIT }, /* Loongson HDAudio*/ { PCI_VDEVICE(LOONGSON, PCI_DEVICE_ID_LOONGSON_HDA), .driver_data = AZX_DRIVER_LOONGSON }, diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 1cde2a69bdb4..58ae77aa1ad9 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -4501,6 +4501,8 @@ static int patch_gf_hdmi(struct hda_codec *codec) return 0; } +static int patch_zx_hdmi(struct hda_codec *codec) { return patch_gf_hdmi(codec); } + /* * patch entries */ @@ -4607,6 +4609,17 @@ HDA_CODEC_ENTRY(0x11069f80, "VX900 HDMI/DP", patch_via_hdmi), HDA_CODEC_ENTRY(0x11069f81, "VX900 HDMI/DP", patch_via_hdmi), HDA_CODEC_ENTRY(0x11069f84, "VX11 HDMI/DP", patch_generic_hdmi), HDA_CODEC_ENTRY(0x11069f85, "VX11 HDMI/DP", patch_generic_hdmi), +HDA_CODEC_ENTRY(0x1d179f86, "ZX-100S HDMI/DP", patch_generic_hdmi), +HDA_CODEC_ENTRY(0x1d179f87, "ZX-100S HDMI/DP", patch_generic_hdmi), +HDA_CODEC_ENTRY(0x1d179f88, "KX-5000 HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f89, "KX-5000 HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f8a, "KX-6000 HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f8b, "KX-6000 HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f8c, "KX-6000G HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f8d, "KX-6000G HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f8e, "KX-8000 HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f8f, "KX-8000 HDMI/DP", patch_zx_hdmi), +HDA_CODEC_ENTRY(0x1d179f90, "KX-8000 HDMI/DP", patch_zx_hdmi), HDA_CODEC_ENTRY(0x80860054, "IbexPeak HDMI", patch_i915_cpt_hdmi), HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x80862801, "Bearlake HDMI", patch_generic_hdmi),
Add newer HD Audio PCI IDs, and HDMI codec vendor IDs for Zhaoxin. The quirk of AZX_DCAPS_RIRB_PRE_DELAY implies that write response from codec to memory needs delay when synchronized to memory after interrupt happened. For KX-5000 needs raising the priority of write cycles additionally, so add specific register setting codes for it. Because Zhaoxin hardware limitation, set BDL position to 128 to increase interrupt interval. Because Zhaoxin HDMI codec need driver to do actual clean-ups for the linked codec when switch from one codec to another, set no_sticky_stream for Zhaoxin HDMI codec too. Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com> --- sound/pci/hda/hda_controller.c | 17 +++++++++++- sound/pci/hda/hda_controller.h | 2 ++ sound/pci/hda/hda_intel.c | 51 +++++++++++++++++++++++++++++++++- sound/pci/hda/patch_hdmi.c | 13 +++++++++ 4 files changed, 81 insertions(+), 2 deletions(-)