diff mbox series

[01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

Message ID 20230731103518.2906147-2-jagan@edgeble.ai (mailing list archive)
State New, archived
Headers show
Series arm64: rockchip: Add more RV1126 DT nodes | expand

Commit Message

Jagan Teki July 31, 2023, 10:35 a.m. UTC
Document pwm compatible for rv1126 which is fallback compatible
of rk3328-pwm group.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: linux-pwm@vger.kernel.org
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>

 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Uwe Kleine-König July 31, 2023, 2:51 p.m. UTC | #1
On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> Document pwm compatible for rv1126 which is fallback compatible
> of rk3328-pwm group.
> 
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Should this go in via the pwm tree, or together with the other patches
via rockchip?

Best regards
Uwe
Conor Dooley July 31, 2023, 3:48 p.m. UTC | #2
On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> Document pwm compatible for rv1126 which is fallback compatible
> of rk3328-pwm group.
> 
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
> Cc: linux-pwm@vger.kernel.org
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
> 
>  Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> index f2d1dc7e7b3f..65bfb492b3a4 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> @@ -32,6 +32,7 @@ properties:
>                - rockchip,rk3308-pwm
>                - rockchip,rk3568-pwm
>                - rockchip,rk3588-pwm
> +              - rockchip,rv1126-pwm
>            - const: rockchip,rk3328-pwm
>  
>    reg:
> -- 
> 2.25.1
Heiko Stuebner Aug. 9, 2023, 2:02 p.m. UTC | #3
Am Montag, 31. Juli 2023, 16:51:29 CEST schrieb Uwe Kleine-König:
> On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> > Document pwm compatible for rv1126 which is fallback compatible
> > of rk3328-pwm group.
> > 
> > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Should this go in via the pwm tree, or together with the other patches
> via rockchip?

I have no clue, sadly. I _can_ pick it up, but I guess that would
require an Ack from Thierry? Otherwise I guess we'll need to wait
for him.


Heiko
Krzysztof Kozlowski Aug. 15, 2023, 8:59 p.m. UTC | #4
On 09/08/2023 16:02, Heiko Stuebner wrote:
> Am Montag, 31. Juli 2023, 16:51:29 CEST schrieb Uwe Kleine-König:
>> On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
>>> Document pwm compatible for rv1126 which is fallback compatible
>>> of rk3328-pwm group.
>>>
>>> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
>>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> Should this go in via the pwm tree, or together with the other patches
>> via rockchip?
> 
> I have no clue, sadly. I _can_ pick it up, but I guess that would
> require an Ack from Thierry? Otherwise I guess we'll need to wait
> for him.

General preference is that binding goes via subsystem (so Thierry), but
there are no driver changes here and your DTS branch would benefit from
it (less dtbs_check warnings). Therefore I propose - just grab it -
unless Thierry wants other way.

Best regards,
Krzysztof
Uwe Kleine-König Sept. 30, 2023, 7:34 p.m. UTC | #5
Hello Heiko,

On Tue, Aug 15, 2023 at 10:59:57PM +0200, Krzysztof Kozlowski wrote:
> On 09/08/2023 16:02, Heiko Stuebner wrote:
> > Am Montag, 31. Juli 2023, 16:51:29 CEST schrieb Uwe Kleine-König:
> >> On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> >>> Document pwm compatible for rv1126 which is fallback compatible
> >>> of rk3328-pwm group.
> >>>
> >>> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> >>
> >> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >>
> >> Should this go in via the pwm tree, or together with the other patches
> >> via rockchip?
> > 
> > I have no clue, sadly. I _can_ pick it up, but I guess that would
> > require an Ack from Thierry? Otherwise I guess we'll need to wait
> > for him.
> 
> General preference is that binding goes via subsystem (so Thierry), but
> there are no driver changes here and your DTS branch would benefit from
> it (less dtbs_check warnings). Therefore I propose - just grab it -
> unless Thierry wants other way.

There are no other changes on the list to that file, so I don't think
we'll run into conflicts. I guess Thierry doesn't feel strong here, so
I'm with Krzysztof here: Pick up this patch together with patches #2 to
#5.

Best regards
Uwe
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
index f2d1dc7e7b3f..65bfb492b3a4 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
@@ -32,6 +32,7 @@  properties:
               - rockchip,rk3308-pwm
               - rockchip,rk3568-pwm
               - rockchip,rk3588-pwm
+              - rockchip,rv1126-pwm
           - const: rockchip,rk3328-pwm
 
   reg: