| Message ID | 20230801122834.89168-1-wangzhu9@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d3af2f4c0434f3dde7f921f52614af81787bbec6 |
| Headers | show |
| Series | [-next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe() | expand |
Il 01/08/23 14:28, Zhu Wang ha scritto: > When platform_get_irq() is called, the error message has been printed, > so it need not to call dev_err_probe() to present error messages. > > Signed-off-by: Zhu Wang <wangzhu9@huawei.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 8/1/23 05:28, Zhu Wang wrote: > When platform_get_irq() is called, the error message has been printed, > so it need not to call dev_err_probe() to present error messages. > > Signed-off-by: Zhu Wang <wangzhu9@huawei.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c > index 2a079464b398..9cda1005ef01 100644 > --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c > +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c > @@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > - return dev_err_probe(dev, irq, "Failed to get irq\n"); > + return irq; > > /* Assign TCPCI feature and ops */ > priv->tcpci_data.auto_discharge_disconnect = 1;
On Tue, Aug 01, 2023 at 08:28:34PM +0800, Zhu Wang wrote: > When platform_get_irq() is called, the error message has been printed, > so it need not to call dev_err_probe() to present error messages. > > Signed-off-by: Zhu Wang <wangzhu9@huawei.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c > index 2a079464b398..9cda1005ef01 100644 > --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c > +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c > @@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > - return dev_err_probe(dev, irq, "Failed to get irq\n"); > + return irq; > > /* Assign TCPCI feature and ops */ > priv->tcpci_data.auto_discharge_disconnect = 1; > -- > 2.17.1
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c index 2a079464b398..9cda1005ef01 100644 --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c @@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get irq\n"); + return irq; /* Assign TCPCI feature and ops */ priv->tcpci_data.auto_discharge_disconnect = 1;
When platform_get_irq() is called, the error message has been printed, so it need not to call dev_err_probe() to present error messages. Signed-off-by: Zhu Wang <wangzhu9@huawei.com> --- drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)